<div dir="ltr">Thanks for the comments Gonzalo<div>I think all agree to get images from Journal in control panel</div><div>So I will try to made it.</div><div><br></div><div>About destination_path, was needed in case the image were copied to /home/user/Documents/lalala, but if we copy to a static path it wouldn't be needed</div><div><br></div><div>So if we are going to replace GtkMenu would be better to don't touch the journal palette then.</div><div><br></div><div>Thanks again, I will do some work, and send a new pr, for see what you guys, thinks.</div><div><br></div><div>Greetings,</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Ignacio Rodríguez</div><div><a href="https://www.facebook.com/pages/SugarLabs/187845102582" target="_blank">SugarLabs at Facebook</a></div></div></div></div></div></div> <br><div class="gmail_quote">2015-08-07 11:39 GMT-03:00 Gonzalo Odiard <span dir="ltr"><<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">These are the reasons I would prefer add a option to get images from the Journal in the control panel,<div>than add a option to set the image as background in the Journal Object palette:</div><div>* Performance: create the Object palette is a relatively slow task. This feature add the need of check</div><div>the mime type of the object, and is slow too. </div><div>* Would be much easier to implement, and keep the background feature code contained.</div><div>* The Journal code is already complex enough.</div><div>* The actual implementation is a quick hack: in particular on this patch [1]:</div> * Use get_uid_list_cb as a function to get the list of uid selected, and do not work in that way,<div> think on multiple selections in the Journal.</div><div> * Modify VolumeMenu adding a parameter to set if will set the background. Would be better</div><div> create another class and keep the code separated.</div><div> * The modifications on model.py need a deep review. But by example the destination_path</div><div> is not returned for all the operations.<div><br></div><div>If we land the replacement of the GtkMenu, then we would solve the performance part of the problem,</div><div>because we delay the check of the mimetype until the Modal window is created.</div><div>Would be good have a cleaner implementation anyway.</div><div><br><div>[1] <a href="https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487" target="_blank">https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487</a> </div></div></div><div>[2] <a href="http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu" target="_blank">http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu</a></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Wed, Aug 5, 2015 at 8:38 PM, James Cameron <span dir="ltr"><<a href="mailto:quozl@sugarlabs.org" target="_blank">quozl@sugarlabs.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">G'day,<br> <br> Thanks for asking.<br> <br> In 0.106 we have a background control panel which offers images from<br> either the system or the documents path.<br> <br> So for the learner to use a photograph in the journal as background<br> they must open the journal, locate the photograph, copy it to the<br> documents directory, then switch to home view, and open the control<br> panel, choose background, and then locate the photograph again, where<br> it appears twice instead of once.<br> <br> I'd like to see "Use as background" in the journal, because it is a<br> learner-desired method of a journal object, and the journal lists the<br> objects. It will lower the barrier for learning and save time.<br> <br> At the moment, the journal object context menu has Resume, Resume<br> with, Copy to, Duplicate, Send to, View Details, and Erase.<br> <br> I'd like to see "Use as background" in this menu, or in the "Copy to"<br> submenu as you suggest.<br> <br> Also, after or in combination with the above, I'd like to see "Choose<br> from journal" feature in the background control panel. It will be a<br> redundant feature, providing an extra path to the same function. We<br> already have several instances of redundant usage paths, and they<br> serve a good purpose.<br> <br> I'd like to see either a button to press which opens the object<br> picker, or the background control panel to show three groups of<br> images; journal, documents, system.<br> <br> There is an opportunity to review common uses of the object picker to<br> ensure they are all included in the journal object context menu.<br> <br> The other questions you ask are uninteresting implementation details<br> unrelated to design:<br> <br> - whether it qualifies as a Feature in the release process, instead of<br> a defect, (to my mind it is a defect, because you will have added<br> nothing new to Sugar, only fixed a learner experience problem),<br> <br> - moving code around,<br> <br> - access to background model by activities,<br> <br> - whether to keep a redundant copy of the background separate to where<br> it was chosen from.<br> <span><font color="#888888"><br> --<br> James Cameron<br> <a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br> </font></span></div></div><span class=""><div><div>_______________________________________________<br> Sugar-devel mailing list<br> <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> </div></div></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </font></span></div> </blockquote></div><br></div>