<div dir="ltr">Thanks, merged</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 3, 2015 at 1:14 PM, Aneesh Dogra <span dir="ltr"><<a href="mailto:lionaneesh@gmail.com" target="_blank">lionaneesh@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Added: <a href="https://github.com/godiard/sugarlabs-calculate/pull/29" target="_blank">https://github.com/godiard/sugarlabs-calculate/pull/29</a></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 31, 2015 at 6:07 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Anesh, James,<div>As the sugarlabs-caalculate project was inactive from 2013,</div><div>and we had GCI students sending patches, I forked the repository</div><div>and the latest version is here: <a href="https://github.com/godiard/sugarlabs-calculate" target="_blank">https://github.com/godiard/sugarlabs-calculate</a></div><div><br></div><div>I already added a patch similar to Aneesh patch, but made the same mistake,</div><div><br></div><div>Aneesh, please send a patch fixing the error pointed by James to apply in the new repository.</div><div><br></div><div>Gonzalo</div><div><br></div><div><br></div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Fri, Jul 31, 2015 at 3:05 AM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That's almost correct. The license should be after the copyright. So<br>
move line 17 to line 2. ;-}<br>
<br>
On Fri, Jul 31, 2015 at 10:47:00AM +0530, Aneesh Dogra wrote:<br>
> Here you go:<br>
> [1]<a href="https://github.com/lionaneesh/sugarlabs-calculate/commit/" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/commit/</a><br>
> 8df47288de11b9fdc61e4811515110f7b44ee925<br>
<span>><br>
> On Thu, Jul 30, 2015 at 9:34 AM, James Cameron <[2]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote:<br>
><br>
> G'day Aneesh,<br>
><br>
> Thanks for coming back to us on this.<br>
><br>
> Yes, you can do something, and you are the only person who can do it,<br>
> because you are the copyright owner.<br>
><br>
> You just have to edit a file.<br>
><br>
> As an example of a good file, look at plotlib.py, see how it has both<br>
> a copyright (line 2) and a license (lines 4-16).<br>
><br>
</span>> [3]<a href="https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/</a><br>
<span>> plotlib.py<br>
><br>
> It is the layout.py file with a problem.<br>
><br>
</span>> [4]<a href="https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/</a><br>
<span>> layout.py<br>
><br>
> Clone the source code in your git repository<br>
</span>> [5]<a href="https://github.com/lionaneesh/sugarlabs-calculate" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate</a><br>
<span>><br>
> Open the file layout.py, edit it, add the license, commit the changes,<br>
> and then push to your repository.<br>
><br>
> That's all!<br>
><br>
> If you can't push for some reason, you can prepare a git patch and<br>
> post it as a reply. As long as it comes from you.<br>
><br>
> References:<br>
><br>
</span>> [6]<a href="http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html</a><br>
<span>><br>
> On Mon, Jul 27, 2015 at 12:15:11PM +0530, Aneesh Dogra wrote:<br>
> > Hello all,<br>
> ><br>
> > Sorry. I was on a long vacation. Getting back on my emails now. Can I do<br>
> > something about this?<br>
> ><br>
</span>> > On Fri, Jun 19, 2015 at 3:21 AM, Gonzalo Odiard <[1][7]<br>
<span>> <a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>><br>
> > wrote:<br>
> ><br>
> > I am afraid you will find many other activities where the license<br>
> notation<br>
> > is <br>
> > in the same state. <br>
> > If the current maintainer can't solve the problem, I have nothing to<br>
> do,<br>
> > but then don't complain :)<br>
> ><br>
> > Gonzalo<br>
> ><br>
</span>> > On Thu, Jun 18, 2015 at 6:39 PM, James Cameron <[2][8]<br>
<span>> <a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>> wrote:<br>
> ><br>
> > I'm with Jonas on this.<br>
> ><br>
> > The fault is a copyright statement in a work without a license,<br>
> and<br>
> > yes, only the original copyright owner can correct it.<br>
> ><br>
> > In my opinion, that correction can be a mail reply from the<br>
> original<br>
> > copyright owner saying "Gonzalo, please add this license short<br>
> text",<br>
> > or "Gonzalo, please remove the copyright line."<br>
> ><br>
> > (Best is the first).<br>
> ><br>
> > Or it can be a patch.<br>
> ><br>
> > But it's not something the new maintainer can _ever_ do, alone.<br>
> ><br>
> > I now have to reconsider inclusion of this activity. Don't let<br>
> that<br>
> > happen again! ;-)<br>
> ><br>
> > --<br>
> > James Cameron<br>
</span>> > [3][9]<a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
<span>> ><br>
> ><br>
> ><br>
> > --<br>
> > Gonzalo Odiard<br>
> ><br>
> > SugarLabs - Software for children learning <br>
> ><br>
> > --<br>
> > Regardless, I hope you're well and happy -<br>
> > Aneesh<br>
> ><br>
> > References:<br>
> ><br>
</span>> > [1] mailto:[10]<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a><br>
> > [2] mailto:[11]<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a><br>
> > [3] [12]<a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
><br>
> --<br>
> James Cameron<br>
> [13]<a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
<span>><br>
> --<br>
> Regardless, I hope you're well and happy -<br>
> Aneesh<br>
><br>
</span>> References:<br>
><br>
> [1] <a href="https://github.com/lionaneesh/sugarlabs-calculate/commit/8df47288de11b9fdc61e4811515110f7b44ee925" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/commit/8df47288de11b9fdc61e4811515110f7b44ee925</a><br>
> [2] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a><br>
> [3] <a href="https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/plotlib.py" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/plotlib.py</a><br>
> [4] <a href="https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/layout.py" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate/blob/sugar-0.94/layout.py</a><br>
> [5] <a href="https://github.com/lionaneesh/sugarlabs-calculate" rel="noreferrer" target="_blank">https://github.com/lionaneesh/sugarlabs-calculate</a><br>
> [6] <a href="http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html" rel="noreferrer" target="_blank">http://lists.sugarlabs.org/archive/sugar-devel/2015-June/050399.html</a><br>
> [7] mailto:<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a><br>
> [8] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a><br>
> [9] <a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
> [10] mailto:<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a><br>
> [11] mailto:<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a><br>
> [12] <a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
> [13] <a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
<div><div><br>
--<br>
James Cameron<br>
<a href="http://quozl.linux.org.au/" rel="noreferrer" target="_blank">http://quozl.linux.org.au/</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br></div></div><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><span style="font-size:12.8000001907349px">Regardless, I hope you're well and happy -</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">Aneesh</span><br></div></div></div>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div>
</div>