<div dir="ltr">Hi <span class="" id=":1me.30" tabindex="-1">Sneha</span> and hi everyone,<div><br></div><div>I've seen your additions :)</div><div><br></div><div>I'm working onto the <span class="" id=":1me.31" tabindex="-1">ui</span> changes for the pen/color/size and also on the collaboration mode.</div><div><br></div><div>Those changes will be breaking stuff so what we can do is the following.</div><div><br></div><div>- Fork the project https://<span class="" id=":1me.33" tabindex="-1">github</span>.com/<span class="" id=":1me.34" tabindex="-1">mikklfr</span>/Paint.activity using the <span class="" id=":1me.35" tabindex="-1">github</span> fork button</div><div><br></div><div>- Push your changes onto a branch in order to keep them easily seen and merged</div><div><br></div><div>- When I'll finish my updates you'll be able update your code as well to fit with the new specifications and we'll merge your work onto the app.</div><div><br></div><div>Feel free to send me emails if you have any question.</div><div><br></div><div>Regards</div><div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><span style="font-size:12.8000001907349px">--</span><br></div><div><div dir="ltr"><div dir="ltr"><span style="font-size:small"><span class="" id=":1me.36" tabindex="-1">Michaël</span> <span class="" id=":1me.37" tabindex="-1">Ohayon</span></span></div><div dir="ltr"><div>Innovation Manager @ <span class="" id=":1me.38" tabindex="-1">Epitech</span> Innovation Hub</div><div>Google Summer of Code Student '15</div></div></div></div></div></div></div></div></div> <br><div class="gmail_quote">2015-07-19 6:06 GMT+02:00 <span class="" id=":1me.39" tabindex="-1">Sneha</span> <span class="" id=":1me.40" tabindex="-1">Mohanty</span> <span dir="ltr"><<a href="mailto:sm21483@gmail.com" target="_blank">sm21483@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div>Hi Gonzalo, <br><br></div>Thanks a lot for replying and letting me know all the cool stuff :) . Appreciate it.<br><br></div>Nice suggestions, will do the needful.<br><br></div>By the way, awesome icon store (<a href="https://thenounproject.com/" target="_blank">https://thenounproject.com/ </a>) !! Simply loved it.<br><br></div>I wish to collaborate with Michael too. Will issue a pull request on his repo if he replies to my mail after looking at my additions. (Hope he does)<br><br><br></div>Regards,<br></div>Sneha Mohanty <br><div><div class="h5"><div><div><br><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jul 19, 2015 at 5:20 AM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">A few more comments:<div><br></div><div>1) Instead of create a new repository with the sources, fork Michael repository,</div><div>and learn how to send pull requests.</div><div>You can read about that here <a href="http://developer.sugarlabs.org/contributing.md.html#forking" target="_blank">http://developer.sugarlabs.org/contributing.md.html#forking</a></div><div>Then, separate your changes in small patches, by example, one patch by tool you add.</div><div><br></div><div>2) Make commits with good titles and explanations, like this one:</div><div><a href="https://github.com/sugarlabs/sugar-toolkit-gtk3/commit/034706a482deef3db5e8a93b232882af3224016c" target="_blank">https://github.com/sugarlabs/sugar-toolkit-gtk3/commit/034706a482deef3db5e8a93b232882af3224016c</a></div><div><br></div><div>3) I agree with Puneet's comments. Would be good consolidate the different tools in a</div><div>tools selector like in the Sugar Paint activity, and improve the color selector palette to </div><div>enable configure the tool size and shape, and select custom colors. </div><div><br></div><div>The activity is having nice improvements, if you and Michael can coordinate</div><div>to work together will be perfect.</div><div><br></div><div>About the icons <a href="https://thenounproject.com/" target="_blank">https://thenounproject.com/</a> have a lot to use.</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Sat, Jul 18, 2015 at 8:00 AM, Puneet Kaur <span dir="ltr"><<a href="mailto:puneet.gkaur@gmail.com" target="_blank">puneet.gkaur@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi, checked it out. It seems nice. Just a few recommendations and tasks for you :<div><br></div><div>1. Make a github io page so that its easy for people to experiment directly in the browser - like the one Micheal has (<a href="http://mikklfr.github.io/Paint.activity/" target="_blank">http://mikklfr.github.io/Paint.activity/</a>)</div><div>2. The functionality added by the sketcher, airbrush and ribbon tools is nice and enriches the paint app with the diversity to play with different types of strokes. </div><div> I would request you to put all of these under the palette of stroke rather than having separate tool buttons like we already one in the native sugar paint app ( do have a look into that) attaching the samples along.</div><div>3. Better svgs for the icons would make it perfect.</div><div><br></div><div><br></div><div>I loved the new functionality. Eager to see more of that :)</div><div><br></div><div><br></div><div>Regards,</div><div>Puneet</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jul 18, 2015 at 12:05 PM, Sneha Mohanty <span dir="ltr"><<a href="mailto:sm21483@gmail.com" target="_blank">sm21483@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><br clear="all"></div>Hi Michael, Gonzalo , Manu Sir, Puneet, Lionel and everyone else,<br><br></div>I have made three new additions to Michael's Paint Activity <br><br></div>- sketcher<br><br></div>- Ribbon <br><br></div>-Airbrush<br><br></div>I have done those additions on my github repo here - <a href="https://github.com/SnehaMohanty/MOhayon-Sugar-paint-branch" target="_blank">https://github.com/SnehaMohanty/MOhayon-Sugar-paint-branch</a><br><div><div><div><div><div><div><br><br></div><div>Note: The svg icons as of now, are not well suited for each of the airbrush, ribbon and sketcher , as i haven't made the suitable icons as of yet.<br><br><br></div><div>Screenshots from my additions have been attached with this mail.<br><br><br></div><div>Please take a look and give me a feedback.<br><br></div><div>Regards,<br></div><div>Sneha Mohanty<br></div><div><br><br></div><div><br></div></div></div></div></div></div></div> </blockquote></div><br></div> </div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </font></span></div> </blockquote></div><br><br clear="all"><br><br> </div></div></div></div> </blockquote></div><br></div></div></div>