<div dir="ltr">Hello Sam, Gonzalo,<div><br></div><div>Now the new patch breaks it for Ubuntu 14.04, so I sent a new PR [1] which doesn't break it (see my patch comment), please check it that works in newer Fedora versions.</div><div><br></div><div>Regards,</div><div>Martin.</div><div><br></div><div>Refs:</div><div>1. <a href="https://github.com/sugarlabs/sugar-artwork/pull/68">https://github.com/sugarlabs/sugar-artwork/pull/68</a></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 9:01 AM, Martin Abente <span dir="ltr"><<a href="mailto:martin.abente.lahaye@gmail.com" target="_blank">martin.abente.lahaye@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Will check today! Thanks Gonzalo and Sam!</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 7:29 AM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Martin, <div>Are you ok with this new patch?</div><span><font color="#888888"><div><br></div><div>Gonzalo</div></font></span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 8:22 AM, Sam P. <span dir="ltr"><<a href="mailto:sam@sam.today" target="_blank">sam@sam.today</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Patch: <a href="https://github.com/sugarlabs/sugar-artwork/pull/67" target="_blank">https://github.com/sugarlabs/sugar-artwork/pull/67</a><br></div><div><div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 2, 2015 at 9:15 PM Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Great!</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 2, 2015 at 7:05 AM, Sam P. <span dir="ltr"><<a href="mailto:sam@sam.today" target="_blank">sam@sam.today</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div>Hi Gonzalo,<br><br></div>Testing without your patch it appears that the journal background didn't get broken - so most of the breakage must have been fixed later in the Gtk+ 3.17 cycle!<br><br></div>Using your patch (the 1st one), it fixes the log tree view and the journal still works fine. I will send a patch.<br><br></div>Next time I'll try to be more up to date with how the Gtk+ release cycle works so that I'm not submiting sugar patches for Gtk+ bugs!<br><br></div>Thanks,<br></div>Sam<br></div><div><div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 2, 2015 at 5:02 AM Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">If that don't work, should be good test:<div><br></div><div><div>diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em</div><div>index 67e4e48..af87900 100644</div><div>--- a/gtk3/theme/gtk-widgets.css.em</div><div>+++ b/gtk3/theme/gtk-widgets.css.em</div><div>@@ -221,9 +221,18 @@ column-header .button:hover:active {</div><div> border-width: 0px;</div><div> }</div><div> </div><div>+GtkTreeView row:even {</div><div>+ background-color: @row_even;</div><div>+}</div><div>+</div></div></div><div dir="ltr"><div><div> GtkTreeView row:nth-child(even) {</div><div> background-color: @row_even;</div><div> }</div></div></div><div dir="ltr"><div><div>+</div><div>+GtkTreeView row:odd {</div><div>+ background-color: @row_odd;</div><div>+}</div><div>+</div></div></div><div dir="ltr"><div><div> GtkTreeView row:nth-child(odd) {</div><div> background-color: @row_odd;</div><div> }</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 3:15 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sam, <div>I don't have rawhide installed to test, can you try adding rules for the two new and old ways, like here:</div><div><br></div><div>diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em</div><div>index 67e4e48..d14bbfb 100644</div><div>--- a/gtk3/theme/gtk-widgets.css.em</div><div>+++ b/gtk3/theme/gtk-widgets.css.em</div><div>@@ -221,10 +221,11 @@ column-header .button:hover:active {</div><div> border-width: 0px;</div><div> }</div><div> </div><div>-GtkTreeView row:nth-child(even) {</div><div>+GtkTreeView row:even, GtkTreeView row:nth-child(even) {</div><div> background-color: @row_even;</div><div> }</div><div>-GtkTreeView row:nth-child(odd) {</div><div>+</div><div>+GtkTreeView row:odd, GtkTreeView row:nth-child(odd) {</div><div> background-color: @row_odd;</div><div> }</div><div> </div><div>Works on Gtk 3.16, we need check if works on Gtk 3.18</div><div><br></div><div>Gonzalo</div></div><div class="gmail_extra"><div><div><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 1:29 PM, Martin Abente <span dir="ltr"><<a href="mailto:martin.abente.lahaye@gmail.com" target="_blank">martin.abente.lahaye@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>From the tests I have done, I confirmed it is used in building time, therefore I have reverted the patch until we can determine a better solution.<br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 1, 2015 at 12:05 PM, Martin Abente <span dir="ltr"><<a href="mailto:martin.abente.lahaye@gmail.com" target="_blank">martin.abente.lahaye@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello Sam,<div><div><div><br></div><div>Different people reported an error while building sugar-artwork packages. The error is caused by this commit [1] which makes GTK a building requirement for sugar-artwork, but:</div><div> </div><div>a) if GTK version version is really used on building time, then the approach used in [1] is wrong, because the css would depend on the GTK version on the packager on something that is related to the final user runtime environment.</div><div><br></div><div>b) if the GTK version is only used in running time, then we should make sure it does not become a building requirement.</div><div><br></div></div><div>In either case, it does not seems to make sense to make it a dependency.</div><div><br></div><div>Regards,</div><div>Martin.</div><div><br></div><div><br></div><div>Refs:</div><div>1. <a href="https://github.com/sugarlabs/sugar-artwork/commit/813a2d77d83284b031a4f2bd5775b9f82b12846e" target="_blank">https://github.com/sugarlabs/sugar-artwork/commit/813a2d77d83284b031a4f2bd5775b9f82b12846e</a></div></div></div> </blockquote></div><br></div> </div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </font></span></div> </blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </div> </blockquote></div> </div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </div> </blockquote></div> </div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software [for | by] children learning <br></div></div></div></div></div> </div> </div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div>