<div dir="ltr"><div><div><div><div>Hi Gonzalo,<br><br></div>Removing the mime_type option sounds like a great idea.<br><br></div>I will look further into it tomorrow.<br><br></div>Thanks,<br></div>Sam<br></div><br><div class="gmail_quote">On Tue, Apr 28, 2015 at 6:51 AM Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org">godiard@sugarlabs.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I was looking at the prs and the feature page. I proposed a simple implementation change<div>in the pr, but to keep the discussion more open, I continue here with questions</div><div>about the general design proposed in the feature page [1].</div><div><br></div><div>The wiki say:</div>"An activity can start other activity by:<br>* knowing the activity ID - starts that specific activity<br>* passing a datastore object - if the activity ID is also passed, starts the object with that specific activity. Otherwise starts the first activity that can handle the object.<br>* passing a mime type - if the activity ID is not passed, start the first activity that can handle the mime type."<div><br></div><div>If we only want open objects from the journal (as a book, a draw, etc)</div><div>we need make the object_id mandatory. Right now, the code only require set one of the parameters.</div><div>In this case also, do not have sense pass only a mime_type. Should the activity start with a empty object?</div><div><br></div><div>As described in the wiki we can pass:</div><div>1) activity_id and object_id</div><div>2) object_id</div><div>3) object_id and mime_type (why we need this? the object in the journal should have the right mime)</div><div>4) activity_id (no object is open, the activity starts empty)</div><div>5) mime_type (no object is open, the activity starts empty) </div><div>6) activity_id, object_id and mime_type (should we ignore the mime associated to object_id?)</div><div><br></div><div>I think the more basic use case, start a activity with a object from the journal</div><div>from another activity only require implement the options 1) and 2)</div><div><br></div><div>If we want implement start a activity without any object_id, the only use case I have in mind</div><div>is a activity as Develop running a new instance of a activity. That would be the case 4)</div><div><br></div><div>Then the question is: </div><div>Do we need the other cases?</div><div><br></div><div>If not, we can remove mime_type at all in the function, and simplify a little the logic.</div><div><br></div><div><br></div><div>[1] <a href="http://wiki.sugarlabs.org/go/Features/Start_activity_from_another_activity" target="_blank">http://wiki.sugarlabs.org/go/Features/Start_activity_from_another_activity</a></div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 22, 2015 at 6:40 PM, Sam P. <span dir="ltr"><<a href="mailto:sam.parkinson3@gmail.com" target="_blank">sam.parkinson3@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Gonzalo,<br><div><br><div class="gmail_quote"><span>On Thu, Apr 23, 2015 at 4:14 AM Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div>* It would be nice to have it integrate with the New ASLO and prompt when the user doesn't have an activity and must download one. The New ASLO has data sorted by bundle ID and is collecting mime types for all activities, meaning we have all the data required to make this work. The next question is probably UX. Here is my mockup suggestion: <a href="http://framebox.org/TbEd" target="_blank">http://framebox.org/TbEd</a></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I would prefer land a simple version first (more thinking we have a end for new features in May 18)</div></div></div></div></blockquote><div><br></div></span><div>Cool, so in order to get it merged:<br><br></div><div>* Add a description to the commit<br></div><div>* PEP8<br>* "FIXME, move this to registry.get_activities_for_type(with_parents=True) ?"<br><br></div><div>Anything else?<br></div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div></div>* Does the design deal with all the security stuff?<br></div></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Like what? This is just to start one activity from another with a object from the Journal.</div></div></div></div></blockquote><div><br></div></span><div>Ok, I was just checking. Last discussion was very security orientated.<br><br></div><div>Thanks,<br></div><div>Sam<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><div>Gonzalo</div></div></div></div></blockquote></div></div></div> </blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software for children learning <br></div></div></div> </div></blockquote></div>