<div dir="ltr"><div>Hi,<br></div><div><br></div><div>I have submitted a new patch which work both inside sugar and in other environments.<br><br>Please review: <a href="https://github.com/sugarlabs/sugar/pull/454">https://github.com/sugarlabs/sugar/pull/454</a><br><br></div><div>Thanks,<br>Sam<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Dec 21, 2014 at 12:29 AM, Martin Abente <span dir="ltr"><<a href="mailto:martin.abente.lahaye@gmail.com" target="_blank">martin.abente.lahaye@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello Jerry,<div><br></div><div>Thanks for the report, I have reproduce it, will revert this commit.</div><div><br></div><div>@sam: to reproduce it just run ."/osbuild shell", and from inside the shell run "sugar-install-bundle <your-bundle-flle>".</div><div><br></div><div>With your patch, and as Jerry suggested, this is what happens:</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>[osbuild sugar-build-no-broot]$ sugar-install-bundle /home/tch/Downloads/Abacus-47.1.xo</div></div><div><div>Traceback (most recent call last):</div></div><div><div> File "/home/tch/Devel/sugar-build-no-broot/build/out/install/bin/sugar-install-bundle", line 19, in <module></div></div><div><div> registry = get_registry()</div></div><div><div> File "/home/tch/Devel/sugar-build-no-broot/build/out/install/lib/python2.7/site-packages/jarabe/model/bundleregistry.py", line 652, in get_registry</div></div><div><div> _instance = BundleRegistry()</div></div><div><div> File "/home/tch/Devel/sugar-build-no-broot/build/out/install/lib/python2.7/site-packages/jarabe/model/bundleregistry.py", line 78, in __init__</div></div><div><div> self._mime_defaults = self._load_mime_defaults()</div></div><div><div> File "/home/tch/Devel/sugar-build-no-broot/build/out/install/lib/python2.7/site-packages/jarabe/model/bundleregistry.py", line 147, in _load_mime_defaults</div></div><div><div> f = open(os.environ["SUGAR_MIME_DEFAULTS"], 'r')</div></div><div><div> File "/home/tch/Devel/sugar-build-no-broot/build/out/sandbox/install/lib64/python2.7/UserDict.py", line 23, in __getitem__</div></div><div><div> raise KeyError(key)</div></div><div><div>KeyError: 'SUGAR_MIME_DEFAULTS'</div></div><div><br></div></blockquote>Without the commit works fine.<div><br></div><div>Lets discuss what other solution we can find!</div><div><br></div><div>Regards,</div><div>tch.</div><div><div><br></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Dec 20, 2014 at 6:28 AM, Sam P. <span dir="ltr"><<a href="mailto:sam.parkinson3@gmail.com" target="_blank">sam.parkinson3@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi James,<br><div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Sat, Dec 20, 2014 at 12:37 PM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for highlighting that patch, Jerry.<br> <br> Yes, it looks like it would break olpc-os-builder, and would be a<br> hurdle for adopting any release of Sugar that includes the patch.<br></blockquote><div><br></div></span><div>OK, let's fix this. Maybe we could run a check to check is sugar is running. If sugar is running, use the registry (so the list is updated). If sugar is not running, use bundle.install (like pre-patch).<br></div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> I'd like the patch reverted and rewritten, and tested without X or<br> DBus present. That can be simulated by running it in a process with<br> none of the critical environment variables.<br></blockquote><div><br><br></div></span><div>What is your tip for replicating this environment?<br></div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> I didn't get any update from the bug system on ticket #4722, which is<br> a surprise. I also didn't get any notification of a patch available<br> for review.<br></blockquote><div><br></div></span><div>That's weird. I did submit a pull request which was merged by Gonzalo a little while back (a few days after submitting the pull request).<br><br></div><div>Thanks,<br></div><div>Sam<br></div><div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><div><br> On Fri, Dec 19, 2014 at 06:22:41PM -0600, Jerry Vonau wrote:<br> > Hi Sam,<br> ><br> > > On December 19, 2014 at 5:40 PM "Sam P." <<a href="mailto:sam.parkinson3@gmail.com" target="_blank">sam.parkinson3@gmail.com</a>><br> > > wrote:<br> > ><br> > ><br> > > Hi Jerry,<br> > ><br> > > I would guess that it does require X. The rational for using<br> > > BundleRegistry is that it emits all the right signals to the gui of<br> > > sugar,<br> > > which requires X.<br> > ><br> > > I havn't tested it against OOB, but maybe I could add a "--no-registry"<br> > > option in sugar-install-bundle? Would that fix the issue?<br> > ><br> ><br> > I'll defer that to quozl as he is the reporter and the current maintainer<br> > of OOB. I haven't looked at other distros yet, but mktinycorexo would<br> > suffer the same fate. Given the low priority assigned to the bug I'd revert<br> > and not break other scripts that might be out in the wild.<br> ><br> > Just my thoughts,<br> ><br> > Jerry<br> > <br> > > Thanks,<br> > > Sam<br> > ><br> > > On Sat, Dec 20, 2014 at 10:18 AM, Jerry Vonau <<a href="mailto:me@jvonau.ca" target="_blank">me@jvonau.ca</a>> wrote:<br> > ><br> > > ><br> > > > Does the use of BundleRegistry()[1] require X to be started? I'm<br> > > > thinking<br> > > > yes as 'protected_activities' in the __init__ part is really a<br> > > > dconf-service setting that is returned as a string. I'm asking as a<br> > > > recent<br> > > > commit was added[2] that just might break olpc-os-builder(OOB). OOB<br> > > > relies<br> > > > upon<br> > > > sugar-install-bundle[3] running in a chroot'ed cli environment where<br> > > > dconf<br> > > > may not be running. Has this change been tested with OOB?<br> > > ><br> > > ><br> > > > Jerry<br> > > ><br> > > > 1.<br> > > ><br> > > > <a href="https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/bundleregistry.py" target="_blank">https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/bundleregistry.py</a><br> > > > 2.<br> > > ><br> > > > <a href="https://github.com/sugarlabs/sugar/commit/d0d045379f097e35c686e9f5dc7f1a0a231041bd" target="_blank">https://github.com/sugarlabs/sugar/commit/d0d045379f097e35c686e9f5dc7f1a0a231041bd</a><br> > > > 3.<br> > > ><br> > > > <a href="http://dev.laptop.org/git/projects/olpc-os-builder/tree/modules/sugar/kspost.75.install_bundles.inc" target="_blank">http://dev.laptop.org/git/projects/olpc-os-builder/tree/modules/sugar/kspost.75.install_bundles.inc</a><br> > > > _______________________________________________<br> > > > Sugar-devel mailing list<br> > > > <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> > > > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> > > ><br> > > _______________________________________________<br> > > Sugar-devel mailing list<br> > > <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> > > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> > _______________________________________________<br> > Sugar-devel mailing list<br> > <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> <br> </div></div><span><font color="#888888">--<br> James Cameron<br> <a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a><br> </font></span></blockquote></div></div></div><br></div></div></div> <br>_______________________________________________<br> Sugar-devel mailing list<br> <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> <br></blockquote></div></div> </div></div></blockquote></div><br></div>