<div dir="ltr">There might be cases where a particular ellipse fits better, but I personally would prefer a general consistency. As Gonzalo mentioned, we don't rely on file extensions, so END would be fitter choice.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 15, 2014 at 6:14 PM, Walter Bender <span dir="ltr"><<a href="mailto:walter.bender@gmail.com" target="_blank">walter.bender@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I am happy with defaulting to END but I think we should define a<br>
constant in style.py.<br>
<br>
-walter<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, Dec 15, 2014 at 2:49 PM, Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org">godiard@sugarlabs.org</a>> wrote:<br>
> Hello,<br>
> Thanks for working on this issue.<br>
><br>
> I think we should use Pango.EllipsizeMode.END always to be consistent.<br>
> In particular, when the text is short, like in the palettes, ellipsize<br>
> MIDDLE<br>
> does not provide a good output. Also, we do a ellipsize "by hand"<br>
> in multiple lines in the secondary text on the pallettes.<br>
><br>
> But looking at the code, we have:<br>
><br>
> In the toolkit:<br>
> [gonzalo@localhost sugar-toolkit-gtk3]$ grep -r "Pango.EllipsizeMode." *<br>
> --include=*.py<br>
> src/sugar3/graphics/palettemenu.py:<br>
> self.label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)<br>
> src/sugar3/graphics/menuitem.py:<br>
> label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)<br>
> src/sugar3/graphics/palette.py:<br>
> self._label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)<br>
> src/sugar3/graphics/palette.py:<br>
> self._secondary_label.set_ellipsize(Pango.EllipsizeMode.END)<br>
><br>
> In sugar:<br>
> [gonzalo@localhost sugar]$  grep -r "Pango.EllipsizeMode." * --include=*.py<br>
> extensions/cpsection/keyboard/view.py:        cell.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> extensions/cpsection/keyboard/view.py:        cell.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> extensions/cpsection/keyboard/view.py:        cell.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> extensions/cpsection/keyboard/view.py:        cell.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> src/jarabe/controlpanel/inlinealert.py:<br>
> self._msg_label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)<br>
> src/jarabe/journal/journaltoolbox.py:<br>
> self._label_widget.set_ellipsize(Pango.EllipsizeMode.MIDDLE)<br>
> src/jarabe/journal/listview.py:        self.cell_title.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> src/jarabe/desktop/activitieslist.py:        cell_text.props.ellipsize =<br>
> Pango.EllipsizeMode.MIDDLE<br>
> src/jarabe/frame/notification.py:<br>
> summary_label.set_ellipsize(Pango.EllipsizeMode.END)<br>
> src/jarabe/frame/notification.py:<br>
> body_label.set_ellipsize(Pango.EllipsizeMode.END)<br>
> src/jarabe/frame/activitiestray.py:<br>
> label.set_ellipsize(Pango.EllipsizeMode.END)<br>
><br>
> The only explanation I found to use ellipsize MIDDLE is need show by example<br>
> a file extension in a file manager. But Sugar does not use file extensions<br>
> in the Journal,<br>
> only in external devices.<br>
><br>
> What others think?<br>
><br>
> Gonzalo<br>
><br>
><br>
><br>
><br>
> On Mon, Dec 15, 2014 at 4:32 PM, Goutam Nair <<a href="mailto:goutamnair7@gmail.com">goutamnair7@gmail.com</a>> wrote:<br>
>><br>
>> Hey all,<br>
>><br>
>> For this bug <a href="http://bugs.sugarlabs.org/ticket/1429" target="_blank">http://bugs.sugarlabs.org/ticket/1429</a>, when the cursor hovers<br>
>> over the activity icon the ellipses are in the middle when it is supposed to<br>
>> be at the end.<br>
>><br>
>> So, in order to fix that, should I have to change this file as well:<br>
>> sugar3/graphics/palette.py on line 143?<br>
>><br>
>> Thanks<br>
>> Goutam Nair<br>
>><br>
>> _______________________________________________<br>
>> Sugar-devel mailing list<br>
>> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
>> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
>><br>
><br>
><br>
> --<br>
> Gonzalo Odiard<br>
><br>
> SugarLabs - Software for children learning<br>
><br>
> _______________________________________________<br>
> Sugar-devel mailing list<br>
> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
><br>
<br>
<br>
<br>
--<br>
</div></div><span class="HOEnZb"><font color="#888888">Walter Bender<br>
Sugar Labs<br>
<a href="http://www.sugarlabs.org" target="_blank">http://www.sugarlabs.org</a><br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</div></div></blockquote></div></div>