<div dir="ltr">Hello,<div>Thanks for working on this issue.</div><div><br></div><div>I think we should use Pango.EllipsizeMode.END always to be consistent.</div><div>In particular, when the text is short, like in the palettes, ellipsize MIDDLE </div><div>does not provide a good output. Also, we do a ellipsize "by hand"</div><div>in multiple lines in the secondary text on the pallettes. </div><div><br></div><div>But looking at the code, we have:</div><div><br></div><div>In the toolkit:</div><div><div>[gonzalo@localhost sugar-toolkit-gtk3]$ grep -r "Pango.EllipsizeMode." * --include=*.py</div><div>src/sugar3/graphics/palettemenu.py: self.label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)</div><div>src/sugar3/graphics/menuitem.py: label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)</div><div>src/sugar3/graphics/palette.py: self._label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)</div><div>src/sugar3/graphics/palette.py: self._secondary_label.set_ellipsize(Pango.EllipsizeMode.END)</div></div><div><br></div><div>In sugar:</div><div><div>[gonzalo@localhost sugar]$ grep -r "Pango.EllipsizeMode." * --include=*.py</div><div>extensions/cpsection/keyboard/view.py: cell.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>extensions/cpsection/keyboard/view.py: cell.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>extensions/cpsection/keyboard/view.py: cell.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>extensions/cpsection/keyboard/view.py: cell.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>src/jarabe/controlpanel/inlinealert.py: self._msg_label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)</div><div>src/jarabe/journal/journaltoolbox.py: self._label_widget.set_ellipsize(Pango.EllipsizeMode.MIDDLE)</div><div>src/jarabe/journal/listview.py: self.cell_title.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>src/jarabe/desktop/activitieslist.py: cell_text.props.ellipsize = Pango.EllipsizeMode.MIDDLE</div><div>src/jarabe/frame/notification.py: summary_label.set_ellipsize(Pango.EllipsizeMode.END)</div><div>src/jarabe/frame/notification.py: body_label.set_ellipsize(Pango.EllipsizeMode.END)</div><div>src/jarabe/frame/activitiestray.py: label.set_ellipsize(Pango.EllipsizeMode.END)</div></div><div><br></div><div>The only explanation I found to use ellipsize MIDDLE is need show by example</div><div>a file extension in a file manager. But Sugar does not use file extensions in the Journal,</div><div>only in external devices.</div><div><br></div><div>What others think? </div><div><br></div><div>Gonzalo</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 15, 2014 at 4:32 PM, Goutam Nair <span dir="ltr"><<a href="mailto:goutamnair7@gmail.com" target="_blank">goutamnair7@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-size:13px">Hey all,</span><div style="font-size:13px"><br></div><div style="font-size:13px">For this bug <a href="http://bugs.sugarlabs.org/ticket/1429" target="_blank">http://bugs.sugarlabs.org/ticket/1429</a>, when the cursor hovers over the activity icon the ellipses are in the middle when it is supposed to be at the end. </div><div style="font-size:13px"><br></div><div style="font-size:13px">So, in order to fix that, should I have to change this file as well: sugar3/graphics/palette.py on line 143?</div><div style="font-size:13px"><br></div><div style="font-size:13px">Thanks</div><span class="HOEnZb"><font color="#888888"><div style="font-size:13px">Goutam Nair</div></font></span></div>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software for children learning <br></div></div></div>
</div>