I probably added some confusion with my testing. Some of those emails was me opening/closing pull requests etc. I'm not completely sure, but I suspect no emails are sent at all for this, the idea being that when a reviewer looks at the pull request the status will almost certainly be there. Though for the submitter an email on failure could actually be handy, ideally to him only to avoid spamming the reviewers... Maybe let's see how it behaves exactly when someone submits a new pull request, then perhaps we can see better how to tweak it.<br>
<br>On Monday, 7 April 2014, Gonzalo Odiard <<a href="mailto:godiard@sugarlabs.org">godiard@sugarlabs.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I asked because I received the mails yesterday for every pull request,<div>and then when was opened and closed,</div>but not when a build failed. Even in "Test breaking build (#332)"<br>May be is only received by who sent the pr?<div>
<br></div><div>Gonzalo</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 7, 2014 at 6:23 AM, Daniel Narvaez <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','dwnarvaez@gmail.com');" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Did you see the "details" link? It's the same link we receive by email.<div><div>
<br><br>On Monday, 7 April 2014, Gonzalo Odiard <<a href="javascript:_e(%7B%7D,'cvml','godiard@sugarlabs.org');" target="_blank">godiard@sugarlabs.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Nice trick. Is possible add a comment with the build result,<div>then we receive a mail? (Or at least in the fail case)</div><div><br></div><div>Gonzalo</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sun, Apr 6, 2014 at 6:20 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">It starts a build whenever a pr is opened or reopened, while it's building it shows that there is a build pending, then it changes the status to success/failure. It also starts a new build if commits are added or changed.<br>
</div><div class="gmail_extra"><div><br><br><div class="gmail_quote">On 6 April 2014 21:17, Manuel Quiñones <span dir="ltr"><<a>manuq@laptop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
2014-04-05 21:51 GMT-03:00 Daniel Narvaez <<a>dwnarvaez@gmail.com</a>>:<br>
<div><div>> Hey,<br>
><br>
> I have finally setup integration between pull requests and buildbot.<br>
><br>
> When you push a pull request buildbot will trigger a build and update the<br>
> github UI to indicate success or failure. The idea is that we should not<br>
> normally merge a pull request unless the build was successful.<br>
><br>
> You can open the build page by clicking on the "details" link. If the build<br>
> failed for reasons which are not related to the patches, you can use the<br>
> "Rebuild" button to retry it.<br>
><br>
> The integration is done with a very simple node server<br>
> <a href="https://github.com/sugarlabs/sugar-gitbot/blob/master/app.js" target="_blank">https://github.com/sugarlabs/sugar-gitbot/blob/master/app.js</a><br>
> I don't expect it to be particularly solid yet, so if you run into any issue<br>
> please let me know!<br>
<br>
</div></div>Great work! I see it is running well. So it closes the PR while<br>
checking and then if check succeeds reopens it again?<br>
<span><font color="#888888"><br>
--<br>
.. manuq ..<br>
</font></span></blockquote></div><br><br clear="all"><br></div><span><font color="#888888">-- <br>Daniel Narvaez<br>
</font></span></div>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a>Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software for children learning <br></div></div>
</div>
</blockquote><br><br></div></div><span><font color="#888888">-- <br>Daniel Narvaez<br><br>
</font></span><br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','Sugar-devel@lists.sugarlabs.org');" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Software for children learning <br></div></div>
</div>
</blockquote><br><br>-- <br>Daniel Narvaez<br><br>