<div>Hi Daniel,</div>
Thanks a lot for the review.<div><br></div><div>I don't know if this is the correct way to submit a question, I have looked everywhere for API docs of GdkPixbuf.hash and can't seem to find it. It requires a parameter but I don't know what it's supposed to be </div><div><br></div><div>Try as I might, from the interactive interpreter it even segfaults on me when trying values for this parameter.</div><div><br></div><div>I think I more or less got your suggestion in the attached patch but I still need to make the Pixbuf.hash function work.</div><div><br></div><div>Thanks for your advice,</div><div>Sebastian</div><div><br></div><div>El vie, 21 de mar 2014 a las 5:42 AM, Daniel Narvaez <notifications@github.com> escribió:<br>
<blockquote type="cite"><p>I think it would be hard to support insensitive/badge while bypassing the cache. Also I've seen that hash() is basically free because it's pointer based. So maybe the best approach is to make IconBuffer.get_surface handle self.pixbuf, using hash() for the key? That means we keep around both the pixbuf and the surface which is a bit of waste, but I can't think of a way to avoid that without making very large changes. It won't have a user visible impact for the stuff you are doing so maybe we can deal with that issue if/when we start using big/lots of pixbufs.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/icarito/sugar-toolkit-gtk3/commit/7c6f87aa9d99ad9e88d96942547208c3c69babf4#commitcomment-5754967">view it on GitHub</a>.<img src="https://github.com/notifications/beacon/199755__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMTAxNzc2NCwiZGF0YSI6eyJpZCI6MjgxOTQwNDN9fQ==--619ec498d8e34842ae6d49913b43622a50a24cce.gif" height="1" width="1"></p></blockquote></div>