<div dir="ltr">Thanks Manuq by the review!<div>Comments below<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <br> <br> I think this feature should live in My Settings for the following reasons:<br> <br></blockquote><div><br></div><div><div>When we worked on this we have a doubt about putting it in the cp too,</div><div>finally decided make the UI relative to the Journal because:</div></div><div><br></div><div>* Is a Journal Backup, not a system backup (configs or activities are not backuped)</div> <div>* In the Sugar UI the cp is refered as "Settings". Backup is not a setting,</div><div>but anyway, "Software Update" or "Switch Desktop" are not setting neither...</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> - it is a global operation, like My Settings > Software Update<br> <br> - the patch adds a new modal window that is very similar to My<br> Settings. This is very prone to confusion. And we should aim to have<br> only one modal to not complicate the shell.<br> <br> - the code should live in extensions/cpsection. This way is more<br> separated from the shell. The less shell code we maintain, the<br> better. And the less decoupled from the Journal, the better too (I<br> had to solve one conflict to test it already).<br> <br></blockquote><div><br></div><div><br></div><div>This is not a good argument :)</div><div>We maintain all the extensions included by default in Sugar too :)</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> i can see why is good to have this attached to the Journal, but in my<br> opinion there are more cons than pros going that way.<br> <br></blockquote><div><br></div><div>Finally, I can move it, I would like to know if there are more opinions.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> Design feedback<br> <br> - make the background white like any other CP section<br> - the buttons should not have a border, they should be similar to the<br> ones in CP sectino<br> - the buttons should not enlarge to fit the available space<br> - the icons in buttons are too big, they should be the same size as CP<br> section icons (GRID_CELL_SIZE)<br> - the icons should have black stroke, white fill<br> - the combo box should not enlarge too, use a left-aligned layout,<br> like others CP sections<br> - the progress dialog should be similar than the Software Update progress<br> - Journal should be written with capital letter<br> <br></blockquote><div><br></div><div>Thanks for all these design points, will work on that.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> Testing<br> <br> - "remote backup" did nothing in my Sugar after pressing Continue.<br> When is this option valid? Can this option be avoided in that case?<br> <br></blockquote><div><br></div><div>Already auto-replied :)</div><div><br></div><div>Outside of the color issues, the icons are ok? </div><div><br></div><div>Thanks for taking time to review this.</div><div><br></div><div> Gonzalo</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> References<br> <br> - Sofrware Update progress<br> <a href="https://f.cloud.github.com/assets/83944/2188629/176e3154-9809-11e3-8aad-48afa77743dc.png" target="_blank">https://f.cloud.github.com/assets/83944/2188629/176e3154-9809-11e3-8aad-48afa77743dc.png</a><br> <br> - Combos are too wide:<br> <a href="https://f.cloud.github.com/assets/83944/2188634/2d55f1b4-9809-11e3-85a0-e76286357e91.png" target="_blank">https://f.cloud.github.com/assets/83944/2188634/2d55f1b4-9809-11e3-85a0-e76286357e91.png</a><br> <br> - Icons too big:<br> <a href="https://f.cloud.github.com/assets/83944/2188641/47ec1d5a-9809-11e3-9ae9-ec8a119f84eb.png" target="_blank">https://f.cloud.github.com/assets/83944/2188641/47ec1d5a-9809-11e3-9ae9-ec8a119f84eb.png</a><br> <br> - Suggested style for buttons:<br> <a href="https://f.cloud.github.com/assets/83944/2188681/fad198c8-9809-11e3-9f47-5e836c26844a.png" target="_blank">https://f.cloud.github.com/assets/83944/2188681/fad198c8-9809-11e3-9f47-5e836c26844a.png</a><br> <span class=""><font color="#888888"><br> --<br> .. manuq ..<br> _______________________________________________<br> Sugar-devel mailing list<br> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> </font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Gonzalo Odiard<br><br><div>SugarLabs - Learning Software for children<br></div></div> </div></div></div>