<div dir="ltr"><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153)"><span style="font-family:arial;color:rgb(34,34,34)">On Wed, Jan 22, 2014 at 2:56 PM, Frederick Grose </span><span dir="ltr" style="font-family:arial;color:rgb(34,34,34)"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span><span style="font-family:arial;color:rgb(34,34,34)"> wrote:</span><br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">
<div><div class="h5"><div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153)"><span style="font-family:arial;color:rgb(34,34,34)">On Wed, Jan 22, 2014 at 6:03 AM, Daniel Narvaez </span><span dir="ltr" style="font-family:arial;color:rgb(34,34,34)"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span><span style="font-family:arial;color:rgb(34,34,34)"> wrote:</span><br>
</div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div>On 21 January 2014 03:49, Frederick Grose <span dir="ltr"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153)"><span style="font-family:arial;color:rgb(34,34,34)">On Mon, Jan 20, 2014 at 4:17 PM, Frederick Grose </span><span dir="ltr" style="font-family:arial;color:rgb(34,34,34)"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span><span style="font-family:arial;color:rgb(34,34,34)"> wrote:</span><br>
</div></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Fixes #4410 <a href="https://bugs.sugarlabs.org/ticket/4410" target="_blank">https://bugs.sugarlabs.org/ticket/4410</a><br>
<br>
The 'Discard network history' button is peculiar to Sugar, and<br>
is destructive to all non-wireless connections, despite being in<br>
the 'Wireless' section of the control panel.<br>
<br>
In the proposed patch[0], the code variables and functions are<br>
renamed and coded to be specific to wireless connections.<br>
<br>
The 'Radio' checkbox instruction and 'Discard ...' button are<br>
reworded to avoid confusion over their state and actions.[1]<br>
<br>
If wireless hardware is not present on the system, the 'Wireless'<br>
section of the control panel is excluded.[2]<br>
<br>
[0,1,2] - <a href="https://github.com/sugarlabs/sugar/pull/228" target="_blank">https://github.com/sugarlabs/sugar/pull/228</a><br>
</blockquote></div><br></div></div><div class="gmail_extra"><font color="#000000"><div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153);display:inline"></div></font><span style="font-family:'trebuchet ms',sans-serif">Daniel Narvaez</span><div style="display:inline;font-family:'trebuchet ms',sans-serif">
wrote via</div><span style="font-family:'trebuchet ms',sans-serif"> </span><span style="font-family:'trebuchet ms',sans-serif"><a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a></span></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:13px;font-family:arial,sans-serif">It seems like the code is handling adhoc networks specia</span><span style="font-size:13px;font-family:arial,sans-serif">lly, but I didn't find an explanation of that change. Can you please elaborate on it?</span><span style="color:rgb(0,0,153);font-family:'trebuchet ms',sans-serif"></span></blockquote>
<div><br></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">The current code at,</font></div><div class="gmail_extra"><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><a href="https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/network.py#L835" target="_blank">https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/network.py#L835</a></font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">tests for sugar-internal connections by reading the connection_id string.</font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">The new code </font><span>is specific to wireless connections.</span></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>The first condition, the presence of a wifi_settings list, avoids 7 of the 7 sugar-internal</span></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>connections on XO-1. </span><span>The sugar ad hoc connections are avoided by a second condition,</span></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>the same test as in the currrent code, </span><span>connection_id.startswith(ADHOC_CONNECTION_ID_PREFIX).</span></div></div></div>
</blockquote><div><br></div></div></div><div>So to make that more explicit, compared to the old code we are *not* clearing anymore gsm, mesh and xs_mesh networks. Is that correct?<br></div></div></div></div></blockquote>
<div><br></div></div></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">The sugar-internal gsm, mesh, & xs_mesh connections are not cleared in the old or proposed, new code.</font></div>
<div class="im">
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span style="color:rgb(0,0,153)"></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Do we have another way to clear gsm?<br></div></div></div></div></blockquote><div><br></div></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">There is a separate control panel for GSM modems. I'm not very familiar with it though.</font></div><div class="im"><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><br></font></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">
<div class="gmail_quote"><div>I'm not too sure we should stop clearing mesh and xs_mesh. It is wifi too and it might play a role in the unbreak procedures people have describing in this thread.</div></div></div></div>
</blockquote><div><br></div></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">See above (the sugar-internal mesh and gsm are not cleared). I suppose someone might create another such connection at a command line.</font></div>
<div class="im">
<div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153)"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> What's the harm of doing that?<br></div></div></div></div></blockquote><div><br></div></div><div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">Clearing non-sugar-internal mesh connections should be ok (as that is the current behavior).</font></div><font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">GSM matters might better be handled on its own control panel.</font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000"><br>
</font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">So yes, GSM users creating custom, non-sugar-gsm connections would be affected if they depended on the 'Discard network history' button.</font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">The modemconfiguration panel, though, seems to use only the one GSM_CONNECTION_ID = 'Sugar Modem Connection'</font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">from jarabe.model.network.</font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">So perhaps best for now, to continue to discard non-sugar GSM connections, and test for other GSM connections before excluding that control panel subsection.</font></div></div></div></div></blockquote>
<div><br></div><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">This seems too much of a corner case (along with other manually created, non-wireless connections).</font></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">I'll close the pull request and resubmit changes sequentially as recommended in the other note.</font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">Thanks for reviewing, --Fred</font></div></div></div></div></blockquote><div>
<br></div><div class="gmail_default" style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">There is a new pull request at</font></div><div class="gmail_default"><font color="#000000"><font face="trebuchet ms, sans-serif"><a href="https://github.com/sugarlabs/sugar/pull/234">https://github.com/sugarlabs/sugar/pull/234</a></font><br>
</font></div><div class="gmail_default"><font color="#000000"><font face="trebuchet ms, sans-serif"><br></font></font></div><div class="gmail_default"><font color="#000000"><font face="trebuchet ms, sans-serif">And a feature page here:</font></font></div>
<div class="gmail_default"><font color="#000000"><font face="trebuchet ms, sans-serif"><a href="http://wiki.sugarlabs.org/go/Features/Network_control_panel">http://wiki.sugarlabs.org/go/Features/Network_control_panel</a><br>
</font></font></div><div><br></div><div><br></div></div></div></div>