<div dir="ltr">By the way I think we should probably not block Frederick patch on the UI discussion about being able to forget networks one by one.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 22 January 2014 12:03, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5">On 21 January 2014 03:49, Frederick Grose <span dir="ltr"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153)"><span style="font-family:arial;color:rgb(34,34,34)">On Mon, Jan 20, 2014 at 4:17 PM, Frederick Grose </span><span dir="ltr" style="font-family:arial;color:rgb(34,34,34)"><<a href="mailto:fgrose@gmail.com" target="_blank">fgrose@gmail.com</a>></span><span style="font-family:arial;color:rgb(34,34,34)"> wrote:</span><br>
</div></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Fixes #4410 <a href="https://bugs.sugarlabs.org/ticket/4410" target="_blank">https://bugs.sugarlabs.org/ticket/4410</a><br>
<br>
The 'Discard network history' button is peculiar to Sugar, and<br>
is destructive to all non-wireless connections, despite being in<br>
the 'Wireless' section of the control panel.<br>
<br>
In the proposed patch[0], the code variables and functions are<br>
renamed and coded to be specific to wireless connections.<br>
<br>
The 'Radio' checkbox instruction and 'Discard ...' button are<br>
reworded to avoid confusion over their state and actions.[1]<br>
<br>
If wireless hardware is not present on the system, the 'Wireless'<br>
section of the control panel is excluded.[2]<br>
<br>
[0,1,2] - <a href="https://github.com/sugarlabs/sugar/pull/228" target="_blank">https://github.com/sugarlabs/sugar/pull/228</a><br>
</blockquote></div><br></div></div><div class="gmail_extra"><font color="#000000"><div style="font-family:'trebuchet ms',sans-serif;font-size:small;color:rgb(0,0,153);display:inline"></div></font><span style="font-family:'trebuchet ms',sans-serif">Daniel Narvaez</span><div style="display:inline;font-family:'trebuchet ms',sans-serif">
wrote via</div><span style="font-family:'trebuchet ms',sans-serif"> </span><span style="font-family:'trebuchet ms',sans-serif"><a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a></span></div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:13px;font-family:arial,sans-serif">It seems like the code is handling adhoc networks specia</span><span style="font-size:13px;font-family:arial,sans-serif">lly, but I didn't find an explanation of that change. Can you please elaborate on it?</span><span style="color:rgb(0,0,153);font-family:'trebuchet ms',sans-serif"></span></blockquote>
<div><br></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">The current code at,</font></div><div class="gmail_extra"><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><a href="https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/network.py#L835" target="_blank">https://github.com/sugarlabs/sugar/blob/master/src/jarabe/model/network.py#L835</a></font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000">tests for sugar-internal connections by reading the connection_id string.</font></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><font color="#000000"><br></font></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small">
<font color="#000000">The new code </font><span>is specific to wireless connections.</span></div><div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>The first condition, the presence of a wifi_settings list, avoids 7 of the 7 sugar-internal</span></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>connections on XO-1. </span><span>The sugar ad hoc connections are avoided by a second condition,</span></div>
<div style="font-family:'trebuchet ms',sans-serif;font-size:small"><span>the same test as in the currrent code, </span><span>connection_id.startswith(ADHOC_CONNECTION_ID_PREFIX).</span></div></div></div>
</blockquote><div><br></div></div></div><div>So to make that more explicit, compared to the old code we are *not* clearing anymore gsm, mesh and xs_mesh networks. Is that correct?<br><br></div><div>Do we have another way to clear gsm?<br>
<br>I'm not too sure we should stop clearing mesh and xs_mesh. It is wifi too and it might play a role in the unbreak procedures people have describing in this thread. What's the harm of doing that?<br></div></div>
</div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Daniel Narvaez<br>
</div>