Whoa scary amount of changes! I hope it might be possible to reduce them, for example we could change Icon to handle icon_size in a backward compatible way.<div> </div><div>Though I think we really need to see a grep on Gonzalo collection of all the activities, to be able to decide the best strategy.</div> <div> </div><div>Thanks again for working in this.</div><div> On Friday, 10 January 2014, Ignacio Rodríguez wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > I think we are safe in activities. I will look at Browse. No, this is a "global" problem, just now, I'm removing all IconSizes from core. 2014/1/10, Manuel Quiñones <<a href="javascript:;" onclick="_e(event, 'cvml', 'manuq@laptop.org')">manuq@laptop.org</a>>: > Thanks Ignacio and Daniel for taking action. > > I think we are safe in activities. I will look at Browse. > > > 2014/1/10 Ignacio Rodríguez <<a>nachoel01@gmail.com</a>> > >> Just now: >> >> [image: Imágenes integradas 1] >> >> Working on bugs. >> BTW, gtk2 activities aren't this problem. >> Saludos. >> Ignacio Rodríguez >> >> >> 2014/1/10 Gonzalo Odiard <<a>godiard@sugarlabs.org</a>> >> >>> >>>> For ToolButton the fix should be easy, we just make the Icon >>>> STANDARD_ICON_SIZE. But there might be other cases where these >>>> properties >>>> was used. Hopefully activities are not using Gtk.IconSize directly... >>>> Perhaps you could grep? :) >>>> >>>> >>> I can search later. Anyway should be only activities ported to gtk3. >>> >>> Gonzalo >>> >>> >>>> >>>> >>>> On 10 January 2014 16:51, Gonzalo Odiard <<a>godiard@sugarlabs.org</a>> wrote: >>>> >>>>> I don't understand what is the problem or the use case. Could you >>>>> explain? >>>>> >>>>> Gonzalo >>>>> >>>>> >>>>> On Fri, Jan 10, 2014 at 12:43 PM, Daniel Narvaez >>>>> <<a>dwnarvaez@gmail.com</a>>wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> so, it looks like the GtkSettings icon sizes are ignored with 3.10 >>>>>> (intentionally deprecated). As far as I can tell the default sizes are >>>>>> now >>>>>> just hardcoded. So I think the only way is to pass the size explicitly >>>>>> to >>>>>> Icon. Ignacio is trying to do that in ToolButton, I do wonder if there >>>>>> are >>>>>> other cases, especially in activities. >>>>>> >>>>>> -- >>>>>> Daniel Narvaez >>>>>> >>>>>> _______________________________________________ >>>>>> Sugar-devel mailing list >>>>>> <a>Sugar-devel@lists.sugarlabs.org</a> >>>>>> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Gonzalo Odiard >>>>> >>>>> SugarLabs - Learning Software for children >>>>> >>>> >>>> >>>> >>>> -- >>>> Daniel Narvaez >>>> >>>> _______________________________________________ >>>> Sugar-devel mailing list >>>> <a>Sugar-devel@lists.sugarlabs.org</a> >>>> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> >>>> >>>> >>> >>> >>> -- >>> Gonzalo Odiard >>> >>> SugarLabs - Learning Software for children >>> >>> _______________________________________________ >>> Sugar-devel mailing list >>> <a>Sugar-devel@lists.sugarlabs.org</a> >>> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> >>> >>> >> >> _______________________________________________ >> Sugar-devel mailing list >> <a></a>-- Saludos. Ignacio Rodríguez </blockquote></div> -- Daniel Narvaez