Ouch! Now I see, I had no thought of this issue... Good find!<div><br></div><div>What about using the user agent in isStandalone instead of the protocol? We can make the web activity and the sugar-web-test use two different, recognizable user agents.<br>
<br>On Friday, 20 December 2013, Rogelio Mita wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">
2013/12/19 Daniel Narvaez <span dir="ltr"><<a href="javascript:_e({}, 'cvml', 'dwnarvaez@gmail.com');" target="_blank">dwnarvaez@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div>On 19 December 2013 21:48, Rogelio Mita <span dir="ltr"><<a href="javascript:_e({}, 'cvml', 'rogeliomita@activitycentral.com');" target="_blank">rogeliomita@activitycentral.com</a>></span> wrote:<br>
</div><div class="gmail_extra">
<div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>
<div>All sugar-web's tests are running into activityweb container, using sugar-web-test activity, all url requests which they do, have "http" scheme, and our current implementation of isStandanlone makes check on the current scheme of the request given (<a href="https://github.com/sugarlabs/sugar-web/blob/master/env.js#L40" target="_blank">isStandalone method</a>), then...</div>
</div></div></blockquote><div><br></div></div><div>You mean "activity" scheme right?<br></div></div></div></div></blockquote><div><br></div><div>yes! When run karma tests, the scheme is "http", is not "activity"</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div></div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">
<div><div> functional tests believe are in standalone mode when they use isStandalone method. Mocking this method on unit tests is ok... but we think is not good idea mocking this on functional tests... or yes???</div>
</div></div></blockquote><div><br></div></div><div>Can you explain what you mean with functional tests? (perhaps just lacking terminology on my side).<br></div></div></div></div></blockquote><div><br></div><div>I mean <a href="http://en.wikipedia.org/wiki/Integration_testing" target="_blank">integration tests</a> =)</div>
</div><br><div><br></div>-- <br>Roger<div><br><div><a href="http://activitycentral.com/" target="_blank">Activity Central</a></div></div>
</div></div>
</blockquote></div><br><br>-- <br>Daniel Narvaez<br><br>