<div dir="ltr">Thanks James!<div><a href="https://github.com/ignaciouy/sugar/commit/30a1f7a629979b11084f9d63f9bfcc4166bc9736">https://github.com/ignaciouy/sugar/commit/30a1f7a629979b11084f9d63f9bfcc4166bc9736</a><br></div>
<div><br></div><div>Pushed :)</div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr">Saludos.<div>Ignacio Rodríguez</div></div></div>
<br><br><div class="gmail_quote">2013/12/3 James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tue, Dec 03, 2013 at 09:25:46AM -0200, Ignacio Rodríguez wrote:<br>
> Before taking screenshot the frame hides automatically<br>
><br>
> +    def _take_screenshot(self, frame_):<br>
> +        while frame_.is_visible():<br>
> +            return True<br>
<br>
</div>The "while" should be "if".  (It is not a busy loop, the while loop<br>
will be abandoned in the first iteration).<br>
<div class="im"><br>
> +<br>
> +        take_screenshot()<br>
> +        frame_.show()<br>
<br>
</div>There should be a "return False", for readability and comprehension.<br>
<div class="im HOEnZb"><br>
> After taking screenshot the frame show automatically<br>
><br>
> > is it using any kind of cues to know when the screenshot was taken?<br>
><br>
> No, I don't use signals! take_screenshot() never fails (Same code of Alt+1<br>
> shortcut)<br>
><br>
> Sorry for my bad english :(<br>
><br>
> Grettings,<br>
> Ignacio Rodríguez<br>
<br>
</div><div class="im HOEnZb">> _______________________________________________<br>
> Sugar-devel mailing list<br>
> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br>
<br>
</div><div class="HOEnZb"><div class="h5">--<br>
James Cameron<br>
<a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a><br>
</div></div></blockquote></div><br></div>