Those are hard questions :) I was also thinking about compatibility with old sugar-toolkit-gtk3 versions when we change stuff like getEnvironment.<div><br></div><div>What about having two configurations, one for Sugar running only inside sugar-build (what we have now), the other running into a normal web browser running outside sugar-build. Seems like this would ensure functionality of the contracts we currently care about? The sugar-web inside sugar-build would break if sugar-toolkit-gtk3 doesn't fulfil the the contract.</div>
<div><br></div><div>There is a difference between testing that getEnvironment works or that the bits getEnvironment depend on (window.sugar) works as expected. Perhaps where we think that difference might matter we could also have tests which tests only the contract with toolkit, without other code layers in the middle. But getEnvironment is so thin that it probably doesn't matter at the moment..</div>
<div><br></div><div>We would need to figure out how to automate tests in a normal web browser, but shouldn't be much of a problem.<br><br>On Wednesday, 27 November 2013, Rogelio Mita wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Ok, working on that we have these situations:<div><br></div><div><b>Context:</b></div><div><ul><li>Hard dependecy between repos: sugar-toolkit-gtk3 --> sugar-web<br></li><li>Exists only one "functional test" (Test interaction/contracts between classes) that is not working, ref: <a href="https://github.com/sugarlabs/sugar-web/blob/master/test/envSpec.js#L5" target="_blank">https://github.com/sugarlabs/sugar-web/blob/master/test/envSpec.js#L5</a></li>
<li>We need have 4 "unit test", one per each logic condition in lines <a href="https://github.com/sugarlabs/sugar-web/blob/master/env.js#L10" target="_blank">10</a>, <a href="https://github.com/sugarlabs/sugar-web/blob/master/env.js#L12" target="_blank">12</a>, <a href="https://github.com/sugarlabs/sugar-web/blob/master/env.js#L17" target="_blank">17</a>, <a href="https://github.com/sugarlabs/sugar-web/blob/master/env.js#L21" target="_blank">21</a></li>
</ul><div><b>Plan:</b></div></div><div><ul><li><u>sugar-web:</u></li><ul><li>Doing missing unit tests to begin refactoring for no lead to breakage in existing code</li><li>Repair "functional test" that not running now, if is necessary</li>
<li>Make refactor</li></ul><li><u>sugar-toolkit-gtk3:</u></li><ul><li>same above</li></ul><li><u>sugar-web and sugar-toolkit-gtk3:</u></li><ul><li>Doing functional test to cover the communication between both</li><li>Make refactor</li>
</ul></ul><div><b>Questions:</b></div></div><div><ul><li><b>Where is the right flow to avoid inconcistence between repos?</b></li><ul><li>I mean, if we assume right behaviour on sugar-toolkit-gtk3 and will write code on sugar-web, the sugar-web functionallity only works if sugar-toolkit-gtk3 is also working right and fulfilling the contract</li>
</ul><li><b>Where is the right place to put the test of this contract above?</b></li><ul><li>One idea is make a karma configuration that only works on osbuild.</li><li>Other idea is doing manually =((((, and no place</li>
<li>Other... tying sugar-web to their tests are always executed in osbuild =(((((((</li></ul></ul><div>Regards!</div></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/11/27 Gonzalo Odiard <span dir="ltr"><<a href="javascript:_e({}, 'cvml', 'gonzalo@laptop.org');" target="_blank">gonzalo@laptop.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ok</div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Nov 27, 2013 at 10:48 AM, Daniel Narvaez <span dir="ltr"><<a href="javascript:_e({}, 'cvml', 'dwnarvaez@gmail.com');" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The env variable should be fine. Though can you open a thread about supporting webkit1? I think it's a major decision and we should ensure everyone is in the loop, especially since we had decided to support webkit2 only in the kick of meeting.<div>
<div><br>
<br>On Wednesday, 27 November 2013, Gonzalo Odiard wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Nov 27, 2013 at 10:33 AM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It *might* not be possible to use the same approach on both. Though, interestingly, this is much easier on webkit1 so one way or another it should be possible to make it work.<div>
<br></div><div>We need to merge support for webkitgtk1 upstream if we want upstream patches to be required to not break it.<div><div><br></div></div></div></blockquote><div><br></div><div>True.</div><div><br></div>
<div>If you agree, I can go with the option of the env variable as discussed previously.</div><div><br></div><div>Gonzalo</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><div>
<br>On Wednesday, 27 November 2013, Gonzalo Odiard wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Please remember we will be using web activities with Webkit1 for a while.<div>
Just a note, to be sure we don't go for something Webkit2 only. </div><div><br></div><div>Gonzalo</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Nov 27, 2013 at 10:16 AM, Rogelio Mita <span dir="ltr"><<a>rogeliomita@activitycentral.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div><br><div class="gmail_quote">2013/11/27 Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
My summary email is still valid but for completeness... I'm not sure it's possible even from inside webkit to implement a non-racy window-object-cleared signal.</blockquote></div><br></div>sounds good, I'm sure that python WebKit2 has to provide some solution to this without having to go down a level, if our plan does not work, surely on the list of webkit are going to tell us the right way, when I can, I will try to do the plan</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Regards!<span><font color="#888888"><br><br clear="all"><div><br></div>-- <br>Roger<div><br><div><a href="http://activitycentral.com/" target="_blank">Activity Central</a></div>
</div>
</font></span></div></div>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a>Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div></div><span><font color="#888888"><br><br>-- <br>Daniel Narvaez<br><br>
</font></span></blockquote></div><br></div></div>
</blockquote><br><br></div></div><span><font color="#888888">-- <br>Daniel Narvaez<br><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Roger<div><br><div><a href="http://activitycentral.com/" target="_blank">Activity Central</a></div></div>
</div>
</blockquote></div><br><br>-- <br>Daniel Narvaez<br><br>