<div dir="ltr">No need to apologize, take it like a code review suggestion :)<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 21 November 2013 14:44, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">You are right. I understand your point now, and I apologize by that.<div>I should try your proposed patch before reply too.</div>
<div>May be I am overworked, but is not a good excuse :(</div><div>will try to do better....</div><span class="HOEnZb"><font color="#888888">
<div><br></div><div>Gonzalo</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Nov 21, 2013 at 10:25 AM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>On 21 November 2013 13:03, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Thu, Nov 21, 2013 at 8:58 AM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Sigh.<br><br>It's promoted by the gtk developers in their documentation, not by me. It's designed as a replacement for all the other layout containers. I'm forwarding their recommendation.<br>
</div><div><br></div><div>Also I've been trying it myself before suggesting it in a speficic case, as I did for your patch.<br></div><div><br></div><div>Gonzalo, please can you try to be a little more friendly to people contributions? You are not going to discourage me, but this kind of attitude puts off contributors and that's the last thing we need. Thanks.<br>
<br></div></div></blockquote><div><br></div></div><div>Is not my intention to be not friendly.</div><div>I will try to do better, but please, do not read my comment as bad attitude.</div><div>I do not read your patch corrections as you have bad attitude with my work.</div>
</div></div></div></blockquote><div><br></div><div><br></div></div><div>I know it's not your intention, I'm not taking it personally. But I think you are often being dismissive and that hurts our effort to build a strong community.<br>
</div><div><br>You didn't post a correction to my suggestion. I would have taken a "Are you insane Gtk.Grid sucks because..." well. I love to be corrected.<br><br>Let me summarize what happened:<br></div><div>
<br></div><div>* You posted a patch. It was suboptimal because it created 3 boxes to layout 2 widgets.<br></div><div>* I knew gtk3 had a better way to do this kind of stuff but I never played with it. So I spent an hour understanding how it worked and wrote you an example of how to rework your code to use it.<br>
</div><div>* I noticed our code is basically doing gtk2 layout using gtk3 (in new code), which is bad both for code clarity and performance. So I thought it would be good to let everyone know about the new cool stuff in gtk3 and what gtk developers recommends.<br>
</div><div><br>Instead of commenting on the technical merit of the proposal, you dismissed it. You said *I* should *prove* it's a good idea before recommending it. That way you showed no interest in the idea I posted, only fear that it might hurt. Can we agree that's a dismissive attitude? Do you expect people will get involved if you show no interest of working *with* them? Notice how this is exactly the same thing that got Sebastian mad couple of days ago...<br>
<br></div><div>And here you have not just been dismissive, you are also plain wrong. If the developers of the toolkit we use suggest something in their documentation, I don't think I need to prove they are right. *You* need to prove they are wrong about their own toolkit.<br>
<br></div><div>To answer your irc question. Having been in your situation myself, I don't think this is matter of communication skills (not mainly at least, we know language gets in the way a lot). It's more of an overworked maintainer mindset... Contributions that doesn't help your immediate goals naturally feels more like a treat than a gift. But it's chicken and egg, you are going to be overworked until we have a strong community around this project and we are not going to have one until we dismiss contributions.<br>
<br></div><div>We have an history of being overworked and of being dismissive (like many other free software projects). We need to learn from that history.<br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Daniel Narvaez<br>
</div>