For the comment I mean just something like "This is necessary only to keep gtk2 activities working". It's not obvious unless you know the whole history of those properties.<br><br>On Wednesday, 30 October 2013, Gonzalo Odiard wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, all the affected activities are gtk2 activities.<div><br><div>We removed the code to support service_name in gtk3, </div>
<div>and did not affected the old activities until we ported sugar to gtk3.</div>
<div><br></div><div>About the comment you suggest, do we have any convention for this case? </div><div><br></div><div>Gonzalo </div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 30, 2013 at 12:44 PM, Daniel Narvaez <span dir="ltr"><<a href="javascript:_e({}, 'cvml', 'dwnarvaez@gmail.com');" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This breaks gtk2 activities right? I think that should be considered a bug and thus we should take the patch (I have not reviewed it). I would add a comment though so that when we will finally drop gtk2 support we will remove this too.<div>
<div><div>
<br>On Wednesday, 30 October 2013, Gonzalo Odiard wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Today I received this mail from Esteban Arias in Uruguay:<div>
<br></div><div>"....</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Cuando sugar cambió el toolbar, o cuando se pasó a gtk3, se mantuvo compatibilidad hacia atrás. </div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Pero al pasar a sugar 0.98 varias de las actividades dejaron de funcionar por tener <b>service_name</b> en lugar de<b> bundle_id </b>enel <a href="http://activity.info/" target="_blank">activity.info</a>.</div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Existe alguno parche o alguna solución para evitar cambiar todos los <a href="http://activity.info/" target="_blank">activity.info</a> de las actividades?</div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px">....</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">"</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
Translation:</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">"When sugar changed the toolbar, or when changed to gtk3, background compatibility</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
was maintained. But with the change to 0.98 several activities stoped working because</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">have service_name instead of bundle_id in <a href="http://activity.info" target="_blank">activity.info</a>.</div>
<div style="font-family:arial,sans-serif;font-size:13.333333969116211px">There are a patch or fix to avoid change the <a href="http://activity.info" target="_blank">activity.info</a> file in every activity?"</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
<br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Similar mails reporting errors in activities, and finally found the problem is related to this</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
change are received regularly in support mailing lists as iaep or support-gang.</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
I wanted try what is needed change to make that activities work, and the change is really small. Attached is a patch to sugar-toolkit-gtk3. From my part I think we have broken</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
compatibility without a good reason in this case, and should be solved.</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
What you think about include it in Sugar? </div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px"><br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">Gonzalo</div></div>
</blockquote></div><br><br></div></div><span><font color="#888888">-- <br>Daniel Narvaez<br><br>
</font></span></blockquote></div><br></div>
</blockquote><br><br>-- <br>Daniel Narvaez<br><br>