<html> <head> <style></style></head> <body class='hmmessage'><div dir='ltr'>I think that we must check the GTK-2 version of all activities and fix that<div>problem.</div><div>Gonzalo: you have the list of activities that need be fixed?</div><div><br><br><div><hr id="stopSpelling">Date: Wed, 30 Oct 2013 15:41:56 -0200<br>From: gonzalo@laptop.org<br>To: manuq@laptop.org<br>CC: dwnarvaez@gmail.com; sugar-devel@lists.sugarlabs.org<br>Subject: Re: [Sugar-devel] service_name and bundle_id... again<br><br><div dir="ltr"><br><div class="ecxgmail_extra"><div class="ecxgmail_quote"><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;">Oh, good Gonzalo, this is the bug to solve then. Your patch is in the<br> correct direction, but allows GTK3 activities to use service_name,<br> which I don't think is correct. The fix should allow only GTK2<br> activities to use service_name, and log a deprecation warning message,<br> as you did.<br> <br></blockquote><div><br></div><div>I don't see your point. </div><div><br></div><div>Look at the code. activitybundle.py do not have logic to recognize gtk2 or gtk3</div><div>activities. The patch is simple, why look for a more complicate logic,</div> <div>only to avoid new activities using service_name instead of bundle_id?</div><div><br></div><div>We have a problem with old activities stopping working, not with new activities. </div><div><br></div><div>Gonzalo</div><div> <br></div><div> </div><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;"> Thanks,<br> <span class="ecxHOEnZb"><font color="#888888"><br> --<br> .. manuq ..<br> </font></span></blockquote></div><br></div></div> <br>_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel</div></div> </div></body> </html>