<div dir="ltr">Master.<div><br></div><div>Full log: <a href="http://paste.fedoraproject.org/28781/29226137/">http://paste.fedoraproject.org/28781/29226137/</a></div><div><br></div><div>Gonzalo</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Mon, Jul 29, 2013 at 5:04 PM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Weird. Master or chroot branch? It would be good to post the full trace.<div><div class="h5"><span></span><br><br>On Monday, 29 July 2013, Gonzalo Odiard wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
<div dir="ltr">In my system, running osbuild check get:<div><br></div><div><div>ImportError: No module named modemconfiguration.model</div></div><div><br></div><div>in all the modemconfiguration tests.</div><div><br></div>
<div>All is updated. Tried running, building, pulling and all.</div><div><br></div><div>Gonzalo </div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div class="h5">On Mon, Jul 29, 2013 at 9:44 AM, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Good news! Thank you very much!<br></div><div><div><div><br>
<br><div>On Mon, Jul 29, 2013 at 2:41 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Fixed, gconf was not working at all in the chroot branch. Your tests are all passing now!<br></div><div>
<div><div><br><br><div>On 29 July 2013 12:51, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">OK. Please, take into account I can mock GConf on every test but I don't know if that makes sense.<br>
</div><div><div><div><br><br><div>On Mon, Jul 29, 2013 at 12:33 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Landed your pull request. Now it fails in gconf but I think that's a sugar-build issue, I will take a look at that.<br>
<br></div>Thanks.<br></div><div><div><div><br><br><div>
On 29 July 2013 10:44, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br>Here is my patch: it checks if language code is not defined and use default values in that case.<br><br>[<a href="https://github.com/sugarlabs/sugar/pull/71" target="_blank">https://github.com/sugarlabs/sugar/pull/71</a>]<br>
<br>diff --git a/extensions/cpsection/modemconfiguration/model.py b/extensions/cpsection/modemconfiguration/model.py<br>index c4e354d..a87cb03 100755<br>--- a/extensions/cpsection/modemconfiguration/model.py<br>+++ b/extensions/cpsection/modemconfiguration/model.py<br>
@@ -119,10 +119,15 @@ class ServiceProvidersError(Exception):<br> <br> def _get_name(el):<br> language_code = locale.getdefaultlocale()[0]<br>- lang = language_code.split('_')[0]<br>- lang_ns_attr = '{<a href="http://www.w3.org/XML/1998/namespace%7Dlang" target="_blank">http://www.w3.org/XML/1998/namespace}lang</a>'<br>
<br>- tag = el.find('name[@%s="%s"]' % (lang_ns_attr, lang))<br>+ if language_code is None:<br>+ tag = None<br>+ else:<br>+ lang = language_code.split('_')[0]<br>+ lang_ns_attr = '{<a href="http://www.w3.org/XML/1998/namespace%7Dlang" target="_blank">http://www.w3.org/XML/1998/namespace}lang</a>'<br>
+<br>+ tag = el.find('name[@%s="%s"]' % (lang_ns_attr, lang))<br>+<br> if tag is None:<br> tag = el.find('name')<br> <br>@@ -296,8 +301,11 @@ def __init__(self):<br> def _guess_country_code(self):<br>
"""Return country based on locale lang attribute."""<br> language_code = locale.getdefaultlocale()[0]<br>- lc_list = language_code.split('_')<br>- country_code = lc_list[1].lower() if len(lc_list) >= 2 else ''<br>
+ if language_code is None:<br>+ country_code = ''<br>+ else:<br>+ lc_list = language_code.split('_')<br>+ country_code = lc_list[1].lower() if len(lc_list) >= 2 else ''<br>
return country_code<br> <br> def _get_initials(self):<br><br><br><br><br><br></div><div><div><div><br><br><div>On Mon, Jul 29, 2013 at 10:00 AM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Miguel,<div><br></div><div>I think I misunderstood your analysis of the issue. sugar-build sets LANG to C and I think that's something that should be supported... So I think we should go with 2 in your list of alternatives.<div>
<div><span></span><br>
<br>On Monday, 29 July 2013, Miguel González wrote:<br><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi Daniel,<br><br></div>Could you </div></blockquote></div></div>
</div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></div></div>_______________________________________________<div class="im">
<br>
Sugar-devel mailing list<br>
<a>Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></div></blockquote></div><br></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888"><br><br>-- <br>Daniel Narvaez<br><br>
</font></span></blockquote></div><br></div>