Being shell code I think it's fine to assume the locale has been set. So I'd go <span></span>for 1.<br><br>On Wednesday, 24 July 2013, Miguel González wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div><div><div><div><div>In this case in extensions/cpsection/modemconfiguration/model.py:299<br><br>language_code = locale.getdefaultlocale()[0]<br><br></div>returns None<br><br></div>so one of the test fails:<br>
<br>======================================================================<br>ERROR: test_go_trough_all_combo_options (test_modemconfiguration.ServiceProvidersTest)<br>----------------------------------------------------------------------<br>
Traceback (most recent call last):<br> File "/home/broot/sugar-build/sugar/tests/test_modemconfiguration.py", line 128, in setUp<br> self.db = ServiceProviders()<br> File "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py", line 274, in __init__<br>
country_code, provider_name, plan_idx = self._get_initials()<br> File "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py", line 309, in _get_initials<br>
country_code = self._guess_country_code()<br> File "/home/broot/sugar-build/build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py", line 299, in _guess_country_code<br> lc_list = language_code.split('_')<br>
AttributeError: 'NoneType' object has no attribute 'split'<br><br>----------------------------------------------------------------------<br><br></div>So:<br><br></div>1) Must set a locale in test environment?<br>
<br></div>2) Make code handle this scenario?<br><br></div>3) Both?<br><br><div><div><div><div><br></div></div></div></div></div><div><br><br><div>On Tue, Jul 23, 2013 at 11:56 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Still failing. Could that error be due to non functional gconf?<div><br></div><div><span style="font-family:Helvetica;white-space:nowrap"><a href="http://buildbot.sugarlabs.org/builders/quick/builds/46/steps/shell_2/logs/log" target="_blank">http://buildbot.sugarlabs.org/builders/quick/builds/46/steps/shell_2/logs/log</a></span><br>
</div><div><br></div><div><span></span>I see a gconf error earlier in the log. I haven't yet looked at what is going on with it. Maybe just a missing dependency.<div><div><br><br>On Tuesday, 23 July 2013, Miguel González wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><a href="https://github.com/sugarlabs/sugar-build/pull/22" target="_blank">https://github.com/sugarlabs/sugar-build/pull/22</a><br>
<pre>diff --git a/build/root.json b/build/root.json
index dd496e2..5a72922 100644
--- a/build/root.json
+++ b/build/root.json
@@ -67,6 +67,7 @@
"gstreamer-plugins-espeak",
"telepathy-salut",
"telepathy-gabble",
+ "mobile-broadband-provider-info",
"gnome-themes-standard",
"xorg-x11-drv-evdev",
"xorg-x11-drv-modesetting",
</pre><br></div><div><br><br><div>On Tue, Jul 23, 2013 at 12:53 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yes!<div><span></span><br><br>On Tuesday, 23 July 2013, Miguel González wrote:<br></div><div>
<div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>It fails again [1] because does not find /usr/share/mobile-broadband-provider-info/serviceproviders.xml. <br>
<br></div>It seems this file is included in package mobile-broadband-provider-info [2]. <br><div>
<br></div><div>May I add this package to on root.json sugar group too?<br></div><div><br>[1] <a href="http://buildbot.sugarlabs.org/builders/quick/builds/41/steps/shell_2/logs/stdio" target="_blank">http://buildbot.sugarlabs.org/builders/quick/builds/41/steps/shell_2/logs/stdio</a><br>
<br><br>[2] <a href="https://apps.fedoraproject.org/packages/mobile-broadband-provider-info/" target="_blank">https://apps.fedoraproject.org/packages/mobile-broadband-provider-info/</a><br></div></div><div>
<br><br><div>
On Tue, Jul 23, 2013 at 9:52 AM, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I guess is somethinks like this:<br><br><pre>From 47824c6e7622d0a59c4cf7960b97f63ece3d3623 Mon Sep 17 00:00:00 2001
From: Miguel Gonzalez <<a>migonzalvar@activitycentral.com</a>>
Date: Tue, 23 Jul 2013 09:45:56 +0200
Subject: [PATCH] Add python-mock dependency
---
build/root.json | 1 +
1 file changed, 1 insertion(+)
diff --git a/build/root.json b/build/root.json
index a826029..dd496e2 100644
--- a/build/root.json
+++ b/build/root.json
@@ -53,6 +53,7 @@
"dbus-python",
"python-telepathy",
"python-dateutil",
+ "python-mock",
"gtksourceview3",
"dconf",
"gsettings-desktop-schemas",
--
1.8.1.6
</pre><br><a href="https://github.com/sugarlabs/sugar-build/pull/21" target="_blank">https://github.com/sugarlabs/sugar-build/pull/21</a><br></div><div><div><div><br><br><div>
On Tue, Jul 23, 2013 at 8:45 AM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We need to add python-mock to build/root.json, <span></span>sugar group (chroot branch).<br><div><br></div><div>My fault for forgetting about it when approving the pull request, but I can't fix it myself for a few days.</div>
<span><font color="#888888">
<br><br>-- <br>Daniel Narvaez<br><br>
</font></span></blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br><div dir="ltr">Miguel González<br>Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br>
</div>
</font></span></div>
</blockquote></div><br><br clear="all"></div></blockquote></div></div></blockquote></div></div></blockquote></div></div></div></blockquote></div></div></blockquote><br><br>-- <br>Daniel Narvaez<br><br>