<div dir="ltr"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 4, 2013 at 11:07 AM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,<br><br></div>did we check what is parsing serviceproviders.xml in GNOME? It doesn't seem to be ModemManager so maybe it's not something we can reuse but I'd rather make sure before going with our own parser.<br>
</div><div class="gmail_extra"><br></div></blockquote><div>AFAIK, the Service Provider Database is used by a wizard in NetworkManager. The source code is in "network-manager-applet" [3] not in "NetworkManager" or "ModemManager".<br>
<br><br>[1]: <a href="https://wiki.gnome.org/NetworkManager/MobileBroadband/ServiceProviders">https://wiki.gnome.org/NetworkManager/MobileBroadband/ServiceProviders</a><br><br>[2]: <a href="http://blogs.gnome.org/dcbw/2009/06/22/mobile-broadband-assistant-makes-it-easy/">http://blogs.gnome.org/dcbw/2009/06/22/mobile-broadband-assistant-makes-it-easy/</a><br>
<br>[3]: <a href="https://git.gnome.org/browse/network-manager-applet/tree/src/libnm-gtk/nm-mobile-providers.c">https://git.gnome.org/browse/network-manager-applet/tree/src/libnm-gtk/nm-mobile-providers.c</a><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On 2 July 2013 22:49, Miguel González <span dir="ltr"><<a href="mailto:migonzalvar@activitycentral.com" target="_blank">migonzalvar@activitycentral.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="h5"><div dir="ltr"><div><div>Hello,<br><br>I've just send a pull request with the implementation of 3G database support in control panel modem configuration section.<br>
<br><a href="https://github.com/sugarlabs/sugar/pull/46" target="_blank">https://github.com/sugarlabs/sugar/pull/46</a><br>
<br>In this email, I'm attaching a screenshot to review UI design.<br><br></div><div>About the implementation, some highlights:<br><br>- There is a new config.py file with constants: file paths and GConf keys.<br><br>
- It uses GConf keys to persistently store country, provider and plan selections<br><br></div><div>- In model.py a class controller retrieve data form XML and store selections on GConf<br><br></div><div>- In the view.py, adds a new ScrolledWindow with an upper box for 3 combo provider selection, a separator and a lower box with the previous entries for network settings.<br>
</div><div><br></div><div>- When a plan is selected, network settings are changed using the same methods.<br></div></div><div><br></div><div><br>I have some concerns:<br><br>- Is the GUI correct?<br><br>- File paths should be move to a template <a href="http://config.py.in" target="_blank">config.py.in</a> file?<br>
</div><div><br></div><div>- I have kind of unitary tests for ServiceProviderDatabase class but I don't know exactly where to put them. They use mock library to simulate GConf calls.<br><br></div><div>- Is it necessary to write functional test for view? Is there information about how to do it?<br>
</div><div><div><br><br clear="all"><div>Thank you for your attention.<span><font color="#888888"><br></font></span></div><span><font color="#888888"><div>-- <br><div dir="ltr">Miguel González<br>
Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br>
</div>
</div></font></span></div></div></div>
<br></div></div>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><span class=""><font color="#888888"><br><br clear="all"><br>-- <br>Daniel Narvaez<br>
</font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">Miguel González<br>Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br></div>
</div></div>