<div dir="ltr"><div><div><div>I fixed combo and its label expansion so now they are corrected aligned with entries below. See attached screenshot.<br><br></div>This change is pushed on the same previous pull request [1]. It could be squashed with previous commit so I could send a new pull request if needed.<br>
<br><br></div>About the top label, it already has line-wrap set to True. I tried to force to wrap at 70 chars. My Gtk skills wasn't good enough so I came around to texwrap Python module. There is the patch and I attached a screenshot:<br>
<br>diff --git a/extensions/cpsection/modemconfiguration/view.py b/extensions/cpsection/modemconfiguration/view.py<br>index 331f717..ccdb96b 100644<br>--- a/extensions/cpsection/modemconfiguration/view.py<br>+++ b/extensions/cpsection/modemconfiguration/view.py<br>
@@ -18,6 +18,7 @@<br> # along with this program; if not, write to the Free Software<br> # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 US<br> <br>+import textwrap<br> from gettext import gettext as _<br>
<br> from gi.repository import Gtk<br>@@ -93,7 +94,7 @@ class ModemConfiguration(SectionView):<br> explanation = _('You will need to provide the following information'<br> ' to set up a mobile broadband connection to a'<br>
' cellular (3G) network.')<br>- self._text = Gtk.Label(label=explanation)<br>+ self._text = Gtk.Label(label=textwrap.fill(explanation))<br> self._text.set_line_wrap(True)<br>
self._text.set_alignment(0, 0)<br> main_box.pack_start(self._text, True, False, 0)<br><br></div>Implementation apart, IMO the result is not much better so I *discarded* this patch.<br><div><div><div><br>
<br>
[1]: <a href="https://github.com/sugarlabs/sugar/pull/46">https://github.com/sugarlabs/sugar/pull/46</a><br><br></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 2, 2013 at 10:49 PM, Miguel González <span dir="ltr"><<a href="mailto:migonzalvar@activitycentral.com" target="_blank">migonzalvar@activitycentral.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hello,<br><br>I've just send a pull request with the implementation of 3G database support in control panel modem configuration section.<br>
<br><a href="https://github.com/sugarlabs/sugar/pull/46" target="_blank">https://github.com/sugarlabs/sugar/pull/46</a><br>
<br>In this email, I'm attaching a screenshot to review UI design.<br><br></div><div>About the implementation, some highlights:<br><br>- There is a new config.py file with constants: file paths and GConf keys.<br><br>
- It uses GConf keys to persistently store country, provider and plan selections<br><br></div><div>- In model.py a class controller retrieve data form XML and store selections on GConf<br><br></div><div>- In the view.py, adds a new ScrolledWindow with an upper box for 3 combo provider selection, a separator and a lower box with the previous entries for network settings.<br>
</div><div><br></div><div>- When a plan is selected, network settings are changed using the same methods.<br></div></div><div><br></div><div><br>I have some concerns:<br><br>- Is the GUI correct?<br><br>- File paths should be move to a template <a href="http://config.py.in" target="_blank">config.py.in</a> file?<br>
</div><div><br></div><div>- I have kind of unitary tests for ServiceProviderDatabase class but I don't know exactly where to put them. They use mock library to simulate GConf calls.<br><br></div><div>- Is it necessary to write functional test for view? Is there information about how to do it?<br>
</div><div><div><br><br clear="all"><div>Thank you for your attention.<span class="HOEnZb"><font color="#888888"><br></font></span></div><span class="HOEnZb"><font color="#888888"><div>-- <br><div dir="ltr">Miguel González<br>
Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br>
</div>
</div></font></span></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">Miguel González<br>Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br></div>
</div>