<div dir="ltr">On 13 June 2013 07:56, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org" target="_blank">quozl@laptop.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote:<br>
> Yes, but somebody should provide patches, and do any change needed<br>
> when the maintainers do the review, to be sure we have the quality<br>
> needed upstream.<br>
<br>
</div>Maintainers could do this themselves if they wanted to.<br></blockquote><div><br></div><div>They could or they could have other priorities, which I suspect is the case here.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I'd caution against change given the stability of the feature in the<br>
dextrose deployments.<br></blockquote><div><br></div><div>These patches needs to be reviewed, like any other patch that makes it into the sugar code base. Even assuming they are rock stable, it's not just matter of stability but also of code quality, how do they integrate with existing code etc. If reviewers feels like they are not able to review them in the form they have been submitted, someone needs to refactor them. No way around that.<br>
</div></div></div></div>