<div dir="ltr"><div>Actually volo versioning seems to be more complicated than I thought<br><br><a href="https://github.com/volojs/volo/blob/master/commands/add/doc.md">https://github.com/volojs/volo/blob/master/commands/add/doc.md</a><br>
<br>The part about user/repo/semverVersion in particular.<br><br></div>So we need to figure out exactly how to behave for the different version types, when to use the system library and when the bundled one.<br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On 29 May 2013 15:07, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="im">On 29 May 2013 14:56, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de" target="_blank">simon@schampijer.de</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote">
<div class="im">
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>Don't we include it already in the activity bundle? <a href="https://github.com/sugarlabs/sugar-html-template/blob/master/package.json" target="_blank">https://github.com/sugarlabs/sugar-html-template/blob/master/package.json</a><br>
<br></blockquote><div><br></div></div><div>Yeah, though not quite intentionally I think, it's not used.<br></div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I looked at the volojs docs but couldn't figure out how exactly the version comes into play here.<br>
<a href="https://github.com/volojs/volo/wiki/Library-best-practices#wiki-volodependencies" target="_blank">https://github.com/volojs/<u></u>volo/wiki/Library-best-<u></u>practices#wiki-<u></u>volodependencies</a><br>
<br>
Is that part of the url, like in "github:requirejs/domReady/2.<u></u>0.1"?<br></blockquote><div><br></div></div><div>That url is in the form user/repo/tag, with tag being a git tag or branch. Maybe we can consider unversioned only dependencies in the form user/repo. <br>
</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Maybe that example can help: <a href="https://github.com/volojs/create-responsive-template/blob/master/package.json" target="_blank">https://github.com/volojs/<u></u>create-responsive-template/<u></u>blob/master/package.json</a><br>
<br>
Can you elaborate on who would do the mapping?<div><br></div></blockquote><div><br></div></div><div>This code <a href="https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/activity/htmlactivity.py#L98" target="_blank">https://github.com/sugarlabs/sugar-toolkit-gtk3/blob/master/src/sugar3/activity/htmlactivity.py#L98</a><br>
<br></div><div>It's already mapping request path to local path. We just need to add logic to map lib paths to the system libraries instead of the activity directory.<br> <br></div><div class="im"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
This should give the best of both worlds because the bundles would still be<br>
self contained, but at the same time we would able to use the latest<br>
available version of the library installed in the system.<br>
</blockquote>
<br></div>
So a copy of the library is included into the activity bundle, and if no version is specified for that dependency it is checked if a newer library is installed in the system for usage.<br></blockquote><div><br></div></div>
<div>
I think with the way volo dependencies are specified, we cannot check if the system library is newer. So if no version is specified we always use the system library, if there is one installed.<br></div></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Daniel Narvaez<br>
</div>