<div dir="ltr">Yeah. The pep8 --exclude patch is not very good, so I used pyflakes8.</div><div class="gmail_extra"> <div class="gmail_quote">On 18 May 2013 19:16, Manuel Quiñones <<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the fix. I see that flake8 is the one that was merged. Good. 2013/5/18 Daniel Narvaez <<a href="mailto:dwnarvaez@gmail.com">dwnarvaez@gmail.com</a>>: <div><div class="h5">> <a href="https://github.com/sugarlabs/sugar/pull/66" target="_blank">https://github.com/sugarlabs/sugar/pull/66</a> > > A quick review would be appreciated, to unbreak the build. > > > On 17 May 2013 21:41, Daniel Narvaez <<a href="mailto:dwnarvaez@gmail.com">dwnarvaez@gmail.com</a>> wrote: >> >> >> <a href="http://buildbot.sugarlabs.org/builders/raring-amd64-quick/builds/9/steps/shell_3/logs/stdio" target="_blank">http://buildbot.sugarlabs.org/builders/raring-amd64-quick/builds/9/steps/shell_3/logs/stdio</a> >> >> config.py is autogenerated, so lines can be arbitrary long. >> >> Perhaps the simplest fix it just to use --exclude. >> We could also consider switching to flake8 to run both pyflakes and pep8 >> and be able to skip certain lines. >> Maybe it's overkill though, since we are not needing that feature other >> than for this case. >> (I sort of like the asserts. To silence pyflake when necessary.) >> >> >> -- >> Daniel Narvaez >> > > > > -- > Daniel Narvaez > </div></div>> _______________________________________________ > Sugar-devel mailing list > <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > -- .. manuq .. </blockquote></div> -- Daniel Narvaez </div>