<div dir="ltr">Hey, sorry, I forgot about those. Though I think it's worth to think if we really need them while we are reworking reviews a bit. When is signed-off-by useful in sugar? How is reviewed-by applied? Is it the reviewer which rebase and add them before pushing? <div class="gmail_extra"> <div class="gmail_quote">On 2 April 2013 18:30, Manuel Quiñones <<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi devs, I've seen some movement in current master. I suppose all this was reviewed, but what I wonder is if we are sticking to the signed-off-by / acked-by signing. The commits in question are: commit f423ec21b4bf0d953a470a383cc801b61a087e98 Author: Walter Bender <<a href="mailto:walter.bender@gmail.com">walter.bender@gmail.com</a>> Date: Sat Mar 30 16:06:00 2013 -0400 Add comment box to expanded entry commit 541af0166030a5f3b7b52bdc23d416dbf688b5e9 Author: Walter Bender <<a href="mailto:walter.bender@gmail.com">walter.bender@gmail.com</a>> Date: Sat Mar 30 10:45:22 2013 -0400 Add CommentView widget to expanded entry commit 248a758875e5a02a53ae57980f4fe2f3bb0bb91e Author: Walter Bender <<a href="mailto:walter.bender@gmail.com">walter.bender@gmail.com</a>> Date: Thu Mar 28 15:26:17 2013 -0400 Make a separate method for _write_entry so method can be reused commit 1af4b5ec7f03ed43da1616df946fe936e8577e91 Author: Walter Bender <<a href="mailto:walter.bender@gmail.com">walter.bender@gmail.com</a>> Date: Thu Mar 28 15:25:41 2013 -0400 Pass a widget to _create_scrollable so method can be reused -- .. manuq .. _______________________________________________ Sugar-devel mailing list <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </blockquote></div> -- Daniel Narvaez </div></div>