<div class="gmail_quote">On Wed, Mar 27, 2013 at 11:21 PM, Daniel Narvaez <<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 27 March 2013 17:39, Ajay Garg <<a href="mailto:ajay@activitycentral.com">ajay@activitycentral.com</a>> wrote: > Just one request :: > ============= > > please include the patch ASAP if it works 90% of the time (although it is > working 100% for me at this point :P ). > > If it is thought that some minor-change/bug-fix is needed, it can be done > "in" the mainline. That would save a lot of maintenance costs in maintaining > a singular, big patch. Hi Ajay, I don't know the specific history of this patch but, as a rule, patches should be pushed to mainline when they are fully working, or at least they are thought to be. If the maintainers point out issues, they should be solved before committing. Often the remainning 10% is the one which takes more time to achieve. </blockquote><div> Yes, I understand that :) "My" 10% intended any minor UI-tweaks (string change, text-positioning, etc), that are often not workflow-critical, and very easy to fix. Obviously, anything that breaks any use-case is a reason enough to reject the patch straightaway (even if that is 1% of the case). </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> It's in the maintainers right to pretend they fully like your contribution before they take responsibility for it. They are going to take over a lot of the maintenance costs you are complainig about after all :) If the patch is too big, it's often possible to split it up so that parts of it can be landed earlier. </blockquote><div> Hmm .. it is big .. but I don't really know if any functionality should be broken into several patches, especially if the entire patch is necessary to make the feature work at all. Anyways, decide upon yourself when I float the patch this weekend :) </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> _______________________________________________ Sugar-devel mailing list <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </blockquote></div> -- Regards, Ajay Garg Dextrose Developer Activity Central: <a href="http://activitycentral.com/" style="font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)" target="_blank">http://activitycentral.com</a>