<div class="gmail_quote">On Mon, Mar 11, 2013 at 6:11 PM, Manuel Quiñones <<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> 2013/3/11 Manuel Quiñones <<a href="mailto:manuq@laptop.org">manuq@laptop.org</a>>: <div><div class="h5">> Hi Ajay, thanks for keep working on this one. > > 2013/3/6 Ajay Garg <<a href="mailto:ajay@activitycentral.com">ajay@activitycentral.com</a>>: >> The solution has been build upon the "no-caching" solution provided by erikos at >> <a href="http://bugs.sugarlabs.org/ticket/4419#comment:4" target="_blank">http://bugs.sugarlabs.org/ticket/4419#comment:4</a> >> >> Theerafter, the cause of <a href="http://bugs.sugarlabs.org/attachment/ticket/3833/Screenshot%20of%20_Journal_.png" target="_blank">http://bugs.sugarlabs.org/attachment/ticket/3833/Screenshot%20of%20_Journal_.png</a> >> is not taking "style.GRID_CELL_SIZE" into account, when calucating the alignments for the palettes. >> >> I will have to thank manuq a great deal, for his comment <a href="http://bugs.sugarlabs.org/ticket/3833#comment:11" target="_blank">http://bugs.sugarlabs.org/ticket/3833#comment:11</a>, >> which helped me debug the real issue. >> In particular, his observation that the "landscape"-mode-obscurity occurs only in one of the erikos' solutions; >> while the "portrait-mode-obscurity" occurs only in both of erikos's solutions. >> >> Finally, this patch provides the no-obscurity solution for all cases :) > > I see issues with your patch: > > 1. I can't bring the palettes of device icons (the ones at the bottom > right of the frame) with the screen rotated in portrait mode. > > 2. after rotation I see the shutdown/reboot palette (icon on the right > side of the frame) wrongly placed in landscape mode. See screenshot: > <a href="http://bugs.sugarlabs.org/attachment/ticket/3833/sc.png" target="_blank">http://bugs.sugarlabs.org/attachment/ticket/3833/sc.png</a> > > So it doesn't pass the TestCase: > <a href="http://bugs.sugarlabs.org/ticket/3833#comment:1" target="_blank">http://bugs.sugarlabs.org/ticket/3833#comment:1</a> </div></div>Sorry, I was testing badly. Your patch does solve all the issues. </blockquote><div> Seems we both hit the "Send" button at the same time :) Thanks for the prompt clarification !! </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> With the improvements Simon ask for (long lines + improved commit message), I'm +1 to push. Thanks! </blockquote><div> My pleasure :) </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> -- .. manuq .. </blockquote></div> -- Regards, Ajay Garg Dextrose Developer Activity Central: <a href="http://activitycentral.com/" style="font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)" target="_blank">http://activitycentral.com</a>