Hmm, may be I misreaded.<div>What is trying to solve this patch?</div><div><br></div><div>Gonzalo<br><br><div class="gmail_quote">On Thu, Feb 28, 2013 at 1:01 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">How is this related with collaboration?<span class="HOEnZb"><font color="#888888"><div><br></div></font></span><div><span class="HOEnZb"><font color="#888888">Gonzalo</font></span><div>
<div class="h5"><br><br><div class="gmail_quote">On Thu, Feb 28, 2013 at 12:23 PM, Ajay Garg <span dir="ltr"><<a href="mailto:ajay@activitycentral.com" target="_blank">ajay@activitycentral.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This reverts commit 21af7cc988320c8a53c946253d52fe1bb6ff9a7e.<br>
<br>
Thankfully, we do not lose anything, as the commit 21af7cc988320c8a53c946253d52fe1bb6ff9a7e was just an "optimisation"-commit;<br>
we don't lose anything on the frontend/backend/anywhere :)<br>
<br>
readactivity.py | 10 ++--------<br>
1 files changed, 2 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/readactivity.py b/readactivity.py<br>
index beed2b4..e0f0cf8 100644<br>
--- a/readactivity.py<br>
+++ b/readactivity.py<br>
@@ -710,7 +710,6 @@ class ReadActivity(activity.Activity):<br>
self.metadata['Read_search'] = \<br>
self._edit_toolbar._search_entry.props.text<br>
self.metadata['activity'] = self.get_bundle_id()<br>
- self.metadata['filehash'] = self.filehash<br>
<br>
os.link(self._tempfile, file_path)<br>
<br>
@@ -856,13 +855,8 @@ class ReadActivity(activity.Activity):<br>
self._view_toolbar.set_view(self._view)<br>
self._edit_toolbar.set_view(self._view)<br>
<br>
-<br>
- self.filehash = self.metadata.get('filehash', None)<br>
- if self.filehash is None:<br>
- self.filehash = get_md5(filepath)<br>
- logging.error('Calculate hash %s', self.filehash)<br>
-<br>
- self._bookmarkmanager = BookmarkManager(self.filehash)<br>
+ filehash = get_md5(filepath)<br>
+ self._bookmarkmanager = BookmarkManager(filehash)<br>
self._bookmarkmanager.connect('added_bookmark',<br>
self._added_bookmark_cb)<br>
self._bookmarkmanager.connect('removed_bookmark',<br>
<span><font color="#888888">--<br>
1.7.11.7<br>
<br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</font></span></blockquote></div><br></div></div></div>
</blockquote></div><br></div>