<div class="gmail_quote">On Wed, Feb 27, 2013 at 5:05 AM, Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Thanks Ajay.<div>I have a doubt. Testing after applying the patch,</div><div>can start the activity and join other instance, but can't see the changes</div><div>from one xo in the other. Can you?</div></blockquote><div> a) I tested with bundle-86.2 (after applying this patch) on * build 30 for XO-4 (as the "inviter") * build 30 for XO-1.75 (as the "joiner") Collaboration didn't work :( b) I then re-tested with the SAME bundle, on * DX4 build 14 on XO-4 (as the "inviter") * DX4 build 14 on XO-1.75 (as the "joiner") Collaboration worked fine (I tested with sharing text, and image). There seem to be some platform-exceptions on build 30 in the failure cases, most probably as a result of <a href="http://bugs.sugarlabs.org/ticket/2955">http://bugs.sugarlabs.org/ticket/2955</a>. I will try and confirm, and see if I can make collaboration work on the build 30. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div> </div><div> Gonzalo <div class="gmail_quote"><div class="im">On Thu, Feb 21, 2013 at 8:53 AM, Ajay Garg <<a href="mailto:ajay@activitycentral.com" target="_blank">ajay@activitycentral.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"> This stopped working (for "Write"), since the time <a href="http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/70cee44717d46129419992cd6a7e15472dc1f568" target="_blank">http://git.sugarlabs.org/sugar-toolkit-gtk3/sugar-toolkit-gtk3/commit/70cee44717d46129419992cd6a7e15472dc1f568</a> was pushed. Signed-off-by: Ajay Garg <<a href="mailto:ajay@activitycentral.com" target="_blank">ajay@activitycentral.com</a>> --- AbiWordActivity.py | 21 ++++++++++----------- 1 files changed, 10 insertions(+), 11 deletions(-) diff --git a/AbiWordActivity.py b/AbiWordActivity.py index 35b248c..e95718e 100644 --- a/AbiWordActivity.py +++ b/AbiWordActivity.py @@ -67,7 +67,6 @@ class AbiWordActivity(activity.Activity): # create our main abiword canvas self.abiword_canvas = DocumentView() - self._shared_activity = None self._new_instance = True toolbar_box = ToolbarBox() @@ -182,13 +181,13 @@ class AbiWordActivity(activity.Activity): self.connect('shared', self._shared_cb) - if self._shared_activity: + if self.shared_activity: # we are joining the activity logger.error('We are joining an activity') self.connect('joined', self._joined_cb) - self._shared_activity.connect('buddy-joined', + self.shared_activity.connect('buddy-joined', self._buddy_joined_cb) - self._shared_activity.connect('buddy-left', self._buddy_left_cb) + self.shared_activity.connect('buddy-left', self._buddy_left_cb) if self.get_shared(): # # oh, OK, we've already joined self._joined_cb() @@ -236,8 +235,8 @@ class AbiWordActivity(activity.Activity): logger.error('My Write activity was shared') self._sharing_setup() - self._shared_activity.connect('buddy-joined', self._buddy_joined_cb) - self._shared_activity.connect('buddy-left', self._buddy_left_cb) + self.shared_activity.connect('buddy-joined', self._buddy_joined_cb) + self.shared_activity.connect('buddy-left', self._buddy_left_cb) channel = self.tubes_chan[telepathy.CHANNEL_TYPE_TUBES] logger.error('This is my activity: offering a tube...') @@ -247,13 +246,13 @@ class AbiWordActivity(activity.Activity): def _sharing_setup(self): logger.debug("_sharing_setup()") - if self._shared_activity is None: + if self.shared_activity is None: logger.error('Failed to share or join activity') return - self.conn = self._shared_activity.telepathy_conn - self.tubes_chan = self._shared_activity.telepathy_tubes_chan - self.text_chan = self._shared_activity.telepathy_text_chan + self.conn = self.shared_activity.telepathy_conn + self.tubes_chan = self.shared_activity.telepathy_tubes_chan + self.text_chan = self.shared_activity.telepathy_text_chan self.tube_id = None self.tubes_chan[telepathy.CHANNEL_TYPE_TUBES].connect_to_signal( 'NewTube', self._new_tube_cb) @@ -267,7 +266,7 @@ class AbiWordActivity(activity.Activity): def _joined_cb(self, activity): logger.error("_joined_cb()") - if not self._shared_activity: + if not self.shared_activity: return self.joined = True </div></div>-- 1.7.11.7 <div class="im"> _______________________________________________ Sugar-devel mailing list <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </div></blockquote></div> </div> </blockquote></div> -- Regards, Ajay Garg Dextrose Developer Activity Central: <a href="http://activitycentral.com/" style="font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)" target="_blank">http://activitycentral.com</a>