<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div style="-webkit-text-size-adjust: auto; ">Hi Simon,</div><div style="-webkit-text-size-adjust: auto; "><br></div><div style="-webkit-text-size-adjust: auto; ">Here's my original mockup for the summary text spacing/layout, should give a fair idea for the column proportions and white space between:</div><div style="-webkit-text-size-adjust: auto; "><br></div><div style="-webkit-text-size-adjust: auto; "> <span style="font-size: 15px; line-height: 19px; white-space: nowrap; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); -webkit-text-size-adjust: none; "><a href="http://wiki.sugarlabs.org/go/File:Home_list_view_comment_summary_mockup.png">http://wiki.sugarlabs.org/go/File:Home_list_view_comment_summary_mockup.png</a></span></div><div><span style="font-size: 15px; line-height: 19px; white-space: nowrap; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);"><br></span></div><div><span style="font-size: 15px; line-height: 19px; white-space: nowrap; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);">Regards,</span></div><div><span style="font-size: 15px; line-height: 19px; white-space: nowrap; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);">--Gary<br></span><br><span style="-webkit-text-size-adjust: auto;">On 20 Sep 2012, at 09:01, Simon Schampijer <<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>> wrote:</span><br><br></div><blockquote type="cite" style="-webkit-text-size-adjust: auto; "><div><span>Thanks Gonzalo for your patch!</span><br><span></span><br><span>Gary, Manuel, how should we best represent this visually? Attached is a screenshot of the Activity listview after Gonzalo's changes.</span><br><span></span><br><span>Regards,</span><br><span> Simon</span><br><span></span><br><span></span><br><span>On 09/19/2012 11:47 PM, <a href="mailto:godiard@sugarlabs.org">godiard@sugarlabs.org</a> wrote:</span><br><blockquote type="cite"><span>From: Gonzalo Odiard <<a href="mailto:godiard@gmail.com">godiard@gmail.com</a>></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Signed-off-by: Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>></span><br></blockquote><blockquote type="cite"><span>---</span><br></blockquote><blockquote type="cite"><span> src/jarabe/desktop/activitieslist.py | 27 ++++++++++++---------------</span><br></blockquote><blockquote type="cite"><span> 1 file changed, 12 insertions(+), 15 deletions(-)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py</span><br></blockquote><blockquote type="cite"><span>index fc05594..58e285c 100644</span><br></blockquote><blockquote type="cite"><span>--- a/src/jarabe/desktop/activitieslist.py</span><br></blockquote><blockquote type="cite"><span>+++ b/src/jarabe/desktop/activitieslist.py</span><br></blockquote><blockquote type="cite"><span>@@ -25,7 +25,6 @@ from gi.repository import GConf</span><br></blockquote><blockquote type="cite"><span> from gi.repository import Gtk</span><br></blockquote><blockquote type="cite"><span> from gi.repository import Gdk</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>-from sugar3 import util</span><br></blockquote><blockquote type="cite"><span> from sugar3.graphics import style</span><br></blockquote><blockquote type="cite"><span> from sugar3.graphics.icon import Icon, CellRendererIcon</span><br></blockquote><blockquote type="cite"><span> from sugar3.graphics.xocolor import XoColor</span><br></blockquote><blockquote type="cite"><span>@@ -77,12 +76,9 @@ class ActivitiesTreeView(Gtk.TreeView):</span><br></blockquote><blockquote type="cite"><span> self.append_column(column)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> cell_text = Gtk.CellRendererText()</span><br></blockquote><blockquote type="cite"><span>- cell_text.props.ellipsize = Pango.EllipsizeMode.MIDDLE</span><br></blockquote><blockquote type="cite"><span>- cell_text.props.ellipsize_set = True</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> column = Gtk.TreeViewColumn()</span><br></blockquote><blockquote type="cite"><span> column.props.sizing = Gtk.TreeViewColumnSizing.GROW_ONLY</span><br></blockquote><blockquote type="cite"><span>- column.props.expand = True</span><br></blockquote><blockquote type="cite"><span> column.set_sort_column_id(ListModel.COLUMN_TITLE)</span><br></blockquote><blockquote type="cite"><span> column.pack_start(cell_text, True)</span><br></blockquote><blockquote type="cite"><span> column.add_attribute(cell_text, 'markup', ListModel.COLUMN_TITLE)</span><br></blockquote><blockquote type="cite"><span>@@ -96,24 +92,26 @@ class ActivitiesTreeView(Gtk.TreeView):</span><br></blockquote><blockquote type="cite"><span> column.props.sizing = Gtk.TreeViewColumnSizing.GROW_ONLY</span><br></blockquote><blockquote type="cite"><span> column.props.resizable = True</span><br></blockquote><blockquote type="cite"><span> column.props.reorderable = True</span><br></blockquote><blockquote type="cite"><span>- column.props.expand = True</span><br></blockquote><blockquote type="cite"><span> column.set_sort_column_id(ListModel.COLUMN_VERSION)</span><br></blockquote><blockquote type="cite"><span> column.pack_start(cell_text, True)</span><br></blockquote><blockquote type="cite"><span> column.add_attribute(cell_text, 'text', ListModel.COLUMN_VERSION_TEXT)</span><br></blockquote><blockquote type="cite"><span> self.append_column(column)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> cell_text = Gtk.CellRendererText()</span><br></blockquote><blockquote type="cite"><span>- cell_text.props.xalign = 1</span><br></blockquote><blockquote type="cite"><span>+ cell_text.props.xalign = 0</span><br></blockquote><blockquote type="cite"><span>+ cell_text.props.wrap_width = int(Gdk.Screen.width() / 3)</span><br></blockquote><blockquote type="cite"><span>+ cell_text.props.wrap_mode = Pango.WrapMode.WORD</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> column = Gtk.TreeViewColumn()</span><br></blockquote><blockquote type="cite"><span>- column.set_alignment(1)</span><br></blockquote><blockquote type="cite"><span> column.props.sizing = Gtk.TreeViewColumnSizing.GROW_ONLY</span><br></blockquote><blockquote type="cite"><span> column.props.resizable = True</span><br></blockquote><blockquote type="cite"><span> column.props.reorderable = True</span><br></blockquote><blockquote type="cite"><span> column.props.expand = True</span><br></blockquote><blockquote type="cite"><span>- column.set_sort_column_id(ListModel.COLUMN_DATE)</span><br></blockquote><blockquote type="cite"><span>+ column.props.max_width = int(Gdk.Screen.width() / 3)</span><br></blockquote><blockquote type="cite"><span>+ column.props.spacing = 5</span><br></blockquote><blockquote type="cite"><span>+ column.set_sort_column_id(ListModel.COLUMN_SUMMARY)</span><br></blockquote><blockquote type="cite"><span> column.pack_start(cell_text, True)</span><br></blockquote><blockquote type="cite"><span>- column.add_attribute(cell_text, 'text', ListModel.COLUMN_DATE_TEXT)</span><br></blockquote><blockquote type="cite"><span>+ column.add_attribute(cell_text, 'text', ListModel.COLUMN_SUMMARY)</span><br></blockquote><blockquote type="cite"><span> self.append_column(column)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> self.set_search_column(ListModel.COLUMN_TITLE)</span><br></blockquote><blockquote type="cite"><span>@@ -164,11 +162,10 @@ class ListModel(Gtk.TreeModelSort):</span><br></blockquote><blockquote type="cite"><span> COLUMN_TITLE = 3</span><br></blockquote><blockquote type="cite"><span> COLUMN_VERSION = 4</span><br></blockquote><blockquote type="cite"><span> COLUMN_VERSION_TEXT = 5</span><br></blockquote><blockquote type="cite"><span>- COLUMN_DATE = 6</span><br></blockquote><blockquote type="cite"><span>- COLUMN_DATE_TEXT = 7</span><br></blockquote><blockquote type="cite"><span>+ COLUMN_SUMMARY = 6</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> def __init__(self):</span><br></blockquote><blockquote type="cite"><span>- self._model = Gtk.ListStore(str, bool, str, str, str, str, int, str)</span><br></blockquote><blockquote type="cite"><span>+ self._model = Gtk.ListStore(str, bool, str, str, str, str, str)</span><br></blockquote><blockquote type="cite"><span> self._model_filter = self._model.filter_new()</span><br></blockquote><blockquote type="cite"><span> Gtk.TreeModelSort.__init__(self, model=self._model_filter)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>@@ -208,7 +205,6 @@ class ListModel(Gtk.TreeModelSort):</span><br></blockquote><blockquote type="cite"><span> if activity_info.get_bundle_id() == 'org.laptop.JournalActivity':</span><br></blockquote><blockquote type="cite"><span> return</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>- timestamp = activity_info.get_installation_time()</span><br></blockquote><blockquote type="cite"><span> version = activity_info.get_activity_version()</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> registry = bundleregistry.get_registry()</span><br></blockquote><blockquote type="cite"><span>@@ -224,14 +220,15 @@ class ListModel(Gtk.TreeModelSort):</span><br></blockquote><blockquote type="cite"><span> '<span style="italic" weight="light">%s</span>' % \</span><br></blockquote><blockquote type="cite"><span> (activity_info.get_name(), tags)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>+ summary = activity_info.get_summary()</span><br></blockquote><blockquote type="cite"><span>+</span><br></blockquote><blockquote type="cite"><span> self._model.append([activity_info.get_bundle_id(),</span><br></blockquote><blockquote type="cite"><span> favorite,</span><br></blockquote><blockquote type="cite"><span> activity_info.get_icon(),</span><br></blockquote><blockquote type="cite"><span> title,</span><br></blockquote><blockquote type="cite"><span> version,</span><br></blockquote><blockquote type="cite"><span> _('Version %s') % version,</span><br></blockquote><blockquote type="cite"><span>- int(timestamp),</span><br></blockquote><blockquote type="cite"><span>- util.timestamp_to_elapsed_string(timestamp)])</span><br></blockquote><blockquote type="cite"><span>+ summary])</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> def set_visible_func(self, func):</span><br></blockquote><blockquote type="cite"><span> self._model_filter.set_visible_func(func)</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><span></span><br></div></blockquote><blockquote type="cite" style="-webkit-text-size-adjust: auto; "><div><summary.png></div></blockquote><blockquote type="cite" style="-webkit-text-size-adjust: auto; "><div><span>_______________________________________________</span><br><span>Sugar-devel mailing list</span><br><span><a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a></span><br><span><a href="http://lists.sugarlabs.org/listinfo/sugar-devel">http://lists.sugarlabs.org/listinfo/sugar-devel</a></span><br></div></blockquote></body></html>