<br><br><div class="gmail_quote">On Tue, Sep 11, 2012 at 4:23 PM, Manuel Kaufmann <span dir="ltr"><<a href="mailto:humitos@gmail.com" target="_blank">humitos@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tue, Sep 11, 2012 at 1:37 PM, Martin Langhoff<br>
<<a href="mailto:martin.langhoff@gmail.com">martin.langhoff@gmail.com</a>> wrote:<br>
> - check at the start of the download that it'll fit (with X room to spare)<br>
<br>
</div>This is done in the new version of the patch that I sent.<br>
<div class="im"><br>
> - make damn sure that we handle ENOSPC if the disk does fill up<br>
<br>
</div>I think we can create a new ticket for this feature, and manage it in<br>
a separate patch. In fact, I have some questions about this and I have<br>
to research for a while. Now, is the datastore raising that exception<br>
when the space is not enough or I have to implement it? If it's<br>
already implemented, how I can catch it?<br>
<br></blockquote><div><br></div><div>I don't think should be another ticket, better have a solution looking at the different issues.</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I did a "git grep ENOSPC" inside the "sugar-datastore" source code and<br>
I didn't find anything.<br>
<div class="im"><br></div></blockquote><div><br></div><div>Can you try almost fill the xo and copy a big file with the journal from a pendrive?</div><div>I remember a big message in the screen when this happen, and will point you to the code.</div>
<div> </div><div>Another issue to look is:</div><div><br></div><div>The browser is downloading the file in a temporary place and later moving to the journal or </div><div>is creating a object in the journal while downloading?</div>
<div>Is important to know if the control in the journal will work or not.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
On Tue, Sep 11, 2012 at 6:34 PM, Hal Murray <<a href="mailto:hmurray@megapathdsl.net">hmurray@megapathdsl.net</a>> wrote:<br>
> <a href="mailto:martin.langhoff@gmail.com">martin.langhoff@gmail.com</a> said:<br>
>> Checking in the progress bar... it's optional. Up to you if you want to<br>
>> check there _as well_.<br>
><br>
</div><div class="im">> Sometimes, you don't know at the start how big a download will be.<br>
><br>
> In that case, if you want to stop before filling up the disk, you have to<br>
> check often-enough during the download. The progress bar sounds like a good<br>
> place.<br>
<br></div></blockquote><div><br></div><div>"the progress bar" is not a place :)</div><div>The code in the browse downloading the data trigger events used to update the progress bar.</div><div>We can use this events, but does not have sense check with every event,</div>
<div>but maybe for 1, 5MB or so. </div><div><br></div><div>Gonzalo</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
</div>I'm confused here. Are we going to check this in two different places?<br>
The first one, when the download process is about to start and every<br>
time that Browse gets a new chunk of the file. In case that we are<br>
going to implement this approach, Gonzalo suggested me to check it<br>
every 5Mb downloaded for example instead of every chunk.<br>
<br>
Please, fill a new ticket with this approach if we are going to<br>
implement this feature.<br>
<div class="im HOEnZb"><br>
--<br>
Kaufmann Manuel<br>
Blog: <a href="http://humitos.wordpress.com/" target="_blank">http://humitos.wordpress.com/</a><br>
Porfolio: <a href="http://fotos.mkaufmann.com.ar/" target="_blank">http://fotos.mkaufmann.com.ar/</a><br>
PyAr: <a href="http://www.python.com.ar/" target="_blank">http://www.python.com.ar/</a><br>
</div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</div></div></blockquote></div><br>