<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">> * API changed in the drag and drop code in Gtk<br>
> * Changes in the way to get color information from the theme.<br>
<br>
</div>I would also add in the message that this is because Gtk.Style was<br>
deprecated by Gtk.StyleContext. If you mention it the next time, the<br>
review can be faster too :)<br>
<div><div class="h5"><br></div></div></blockquote><div><br></div><div>Be free to suggest a more descriptive comment.</div><div><br></div><div>....</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
</div></div>Drag and drop is not working for me. A way to test it: drag one color<br>
from the same palette to the toolbar button. Another: add two color<br>
buttons and drag from the palette of one to the other button.<br>
<br>
I will try to figure out the problem and report back.<br>
<br></blockquote><div><br></div><div>Sadly, you are right. Now I have tried a lot, but didn't found what is happening.</div><div>If anybody have a idea, is welcomed. The call back methods for the signals</div><div><div>
'drag_data_received' and 'drag_data_get' are not called.</div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Are the PyGi devs aware that this constants are not being converted in<br>
the pygi-convert script?<br>
<div class="im"><br></div></blockquote><div><br></div><div>I have not reported it yet.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
> + self._preview.stroke_color = self._get_fg_style_color_str()<br>
<br>
</div>I think would be a more readable name: _get_preview_stroke_color.<br>
<div class="im"><br></div></blockquote><div><br></div><div>Well, the method get the foreground color from the style...</div><div>Anyway, if you are happy with other method name, change it.</div><div><br></div><div>....</div>
<div><br></div><div>Gonzalo</div></div>