<br><br><div class="gmail_quote">2012/4/17 Manuel Quiñones <span dir="ltr"><<a href="mailto:manuq@laptop.org">manuq@laptop.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

El día 17 de abril de 2012 12:53, Rafael Ortiz<br>
<<a href="mailto:rafael@activitycentral.com">rafael@activitycentral.com</a>> escribió:<br>
<div><div class="h5">><br>
><br>
> On Tue, Apr 17, 2012 at 10:41 AM, Ariel Calzada <<a href="mailto:ariel.calzada@gmail.com">ariel.calzada@gmail.com</a>><br>
> wrote:<br>
>><br>
>> On 04/17/2012 10:31 AM, Ariel Calzada wrote:<br>
>>><br>
>>> PATCH for Words Activity that fix <a href="https://dev.laptop.org.au/issues/1078" target="_blank">https://dev.laptop.org.au/issues/1078</a><br>
>>> Speak option says the  word twice in words activity.<br>
>>><br>
>>> ---<br>
>>>  wordsactivity.py |    9 ++-------<br>
>>>  1 files changed, 2 insertions(+), 7 deletions(-)<br>
>>><br>
>>> diff --git a/wordsactivity.py b/wordsactivity.py<br>
>>> index 5c241f7..cfb8794 100644<br>
>>> --- a/wordsactivity.py<br>
>>> +++ b/wordsactivity.py<br>
>>> @@ -201,20 +201,15 @@ class WordsActivity(activity.Activity):<br>
>>>          # No Portuguese accent yet.<br>
>>>          if lang == "portuguese":<br>
>>>              lang = "spanish"<br>
>>> -        tmpfile = "/tmp/something.wav"<br>
>>> -        subprocess.call(["espeak", text, "-w", tmpfile, "-v", lang])<br>
>>> -        subprocess.call(["aplay", tmpfile])<br>
>>> -        os.unlink(tmpfile)<br>
>>> -<br>
>>>          #AU costumization<br>
>>> -        if lang == "english":<br>
>>> +        elif lang == "english":<br>
>>>              lang = "english_rp"<br>
>>> +<br>
>>>          tmpfile = "/tmp/something.wav"<br>
>>>          subprocess.call(["espeak", text, "-w", tmpfile, "-v", lang])<br>
>>>          subprocess.call(["aplay", tmpfile])<br>
>>>          os.unlink(tmpfile)<br>
>>><br>
>>> -<br>
>>>      def lang1combo_cb(self, combo):<br>
>>>          pass<br>
>>><br>
<br>
</div></div>Tested, is working propery now, great.<br>
<div class="im"><br>
> Thanks for the catch, applied as<br>
><br>
><br>
> <a href="http://git.sugarlabs.org/words-activity/words-activity/commit/fb3819774867c814a65d201d5b8cdb9d4767702e" target="_blank">http://git.sugarlabs.org/words-activity/words-activity/commit/fb3819774867c814a65d201d5b8cdb9d4767702e</a><br>


<br>
</div>Please take care before commiting, the text in the commit message is duplicated.<br>
<div class="im"><br></div></blockquote><div><br></div><div>Should be git am dup. as the patch has not this duplicated text.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im">
> Will be in next version.<br>
><br>
> Thanks.<br>
><br>
><br>
><br>
</div>> _______________________________________________<br>
> Sugar-devel mailing list<br>
> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
.. manuq ..<br>
</font></span></blockquote></div><br>