Pushed and the ticket closed.<div>Thanks again, and if is your first patch... welcome!</div><div> </div><div>Gonzalo <div class="gmail_quote">On Sat, Mar 17, 2012 at 5:16 PM, Kalpa Welivitigoda <<a href="mailto:callkalpa@gmail.com">callkalpa@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sun, Mar 18, 2012 at 1:06 AM, Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>> wrote: > Thanks Kalpa, > What do you think about replacing: > > - catbox = gtk.Label(c) > + # If there is no category, display as Unknown > + if c is '': > + catbox = gtk.Label(_('Unknown')) > + else: > + catbox = gtk.Label(c) > > by: > > + # If there is no category, display as Unknown > + description = c > + if c is '': > + description = _('Unknown') > catbox = gtk.Label(description) > > Looks simpler, right? > </div>and much better. I've attached the new patch. <div class="HOEnZb"><div class="h5"> > Gonzalo > > On Sat, Mar 17, 2012 at 4:21 PM, <<a href="mailto:callkalpa@gmail.com">callkalpa@gmail.com</a>> wrote: >> >> From: Kalpa Pathum Welivitigoda <<a href="mailto:callkalpa@gmail.com">callkalpa@gmail.com</a>> >> >> --- >> budgetscreen.py | 6 +++++- >> chartscreen.py | 7 +++++-- >> 2 files changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/budgetscreen.py b/budgetscreen.py >> index 0e2cd98..bcbceb5 100644 >> --- a/budgetscreen.py >> +++ b/budgetscreen.py >> @@ -96,7 +96,11 @@ class BudgetScreen(gtk.VBox): >> >> # Build categories. >> for c in self.sorted_categories: >> - catbox = gtk.Label(c) >> + # If there is no category, display as Unknown >> + if c is '': >> + catbox = gtk.Label(_('Unknown')) >> + else: >> + catbox = gtk.Label(c) >> catbox.set_padding(10, 0) >> >> color = finance.get_category_color_str(c) >> diff --git a/chartscreen.py b/chartscreen.py >> index 129be9b..b6d1977 100644 >> --- a/chartscreen.py >> +++ b/chartscreen.py >> @@ -89,8 +89,11 @@ class ChartScreen(gtk.HBox): >> for c in self.sorted_categories: >> hbox = gtk.HBox() >> >> - catlabel = gtk.Label() >> - catlabel.set_markup(c) >> + # If there is no category, display as Unknown >> + if c is '': >> + catlabel = gtk.Label(_('Unknown')) >> + else: >> + catlabel = gtk.Label(c) >> catgroup.add_widget(catlabel) >> >> color = finance.get_category_color_str(c) >> -- >> 1.7.7.6 >> >> _______________________________________________ >> Sugar-devel mailing list >> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> >> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> > > </div></div>-- Best Regards, Kalpa Pathum Welivitigoda <a href="http://about.me/callkalpa" target="_blank">http://about.me/callkalpa</a> </blockquote></div> </div>