<br><br><div class="gmail_quote">On Thu, Jan 19, 2012 at 6:32 AM, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 01/17/2012 10:48 PM, Gonzalo Odiard wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Gonzalo,<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
thanks for the patch! Here are a few notes:<br>
<br>
- when you have a text selected and want it to be spoken out a clipboard<br>
entry is created (I guess you need to have a look at why the clipboard tray<br>
reacts to that selection)<br>
<br>
<br>
</blockquote>
I only see this problem with the Write activity, not with Read, Browse or<br>
Wikipedia-<br>
May be Write is doing anything different with the clipboard?<br>
</blockquote>
<br></div>
Ahh, ok yes - seems to only happen with Write. Can you please have a look why that happens?<div class="im"><br></div></blockquote><div><br><br>Yes.<br><br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- you specify gconf keys, those would need to be added to the schema as<br>
well<br>
<br>
Added.<br>
</blockquote>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- when you select a long text for reading there is no way to pause/stop<br>
it, might be worth having that option as well<br>
<br>
<br>
</blockquote>
It's true. I have added controls to pause/stop in the palette.<br>
I have tried with two options (please see<br>
<a href="http://wiki.sugarlabs.org/go/Talk:Features/Global_Text_To_Speech" target="_blank">http://wiki.sugarlabs.org/go/<u></u>Talk:Features/Global_Text_To_<u></u>Speech</a>)<br>
One option with menu items and the other with buttons. The option with menu<br>
items looks better,<br>
but when the item is activated, the palette close, then if you want<br>
pause/play more than one time<br>
is annoying.<br>
The option with buttons is better for usability, because the palette is not<br>
closed,<br>
but is uglier (the separator does not take all the palette width). Advice<br>
is welcomed.<br>
The code is commented in the patch then is easy test the two options<br>
(SpeechPalette __init__ and _set_buttons_state)<br>
</blockquote>
<br></div>
A technical detail about the new gtk-3 based palettes:<br>
<br>
"...As a result of this, palettes can now pack either a user-defined collection of widgets, or a menu, but types can no longer be mixed. This should only affect a handful of palettes which will need to pick a single approach and convert to it."<br>
<br>
This means the approach with packing menu items into the palettes and having in combination with the sliders is not future proof. Would be good if we could find another way of handling it,other palettes (like the speaker one) will be interested in a solution as well.<div class="im">
<br></div></blockquote><div><br>Hmm, then I will try improve the option with the buttons.<br><br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't know what to do with the hot key. Pause if the user press when a<br>
text is being played?<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- the shortcut is a bit long, maybe 'alt+s' is enough? (see above, maybe<br>
there is a shortcut as well for stopping? or hitting it again does stop the<br>
current playing one?)<br>
<br>
<br>
</blockquote>
Ok, changed. To stop we use Ctrl + q<br>
</blockquote>
<br></div>
'Ctrl+q' is already in use for activity closing, no? Can you elaborate what you are proposing or describing?<br>
<br></blockquote><div><br>I mean, to stop the activities, we use ctrl + q, then, there are not collisions.<br><br>Gary proposed use the same alt + s to play/pause. <br>Do you think we should add a shortcut to stop playing the text?<br>
<br>Gonzalo<br><br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Regards,<br>
Simon<br>
</blockquote></div><br>