Reviewed-by: Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>> <br><br>(the two patches)<br><br>Gonzalo<br><br><div class="gmail_quote">On Wed, Jan 11, 2012 at 3:57 PM, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 11/01/12 17:53, Simon Schampijer wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Use the get_shared_activity method instead<br>
<br>
Signed-off-by: Simon Schampijer<<a href="mailto:simon@laptop.org" target="_blank">simon@laptop.org</a>><br>
---<br>
src/sugar3/activity/activity.<u></u>py | 3 ---<br>
1 files changed, 0 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/sugar3/activity/<u></u>activity.py b/src/sugar3/activity/<u></u>activity.py<br>
index aedcae8..3c1a2f3 100644<br>
--- a/src/sugar3/activity/<u></u>activity.py<br>
+++ b/src/sugar3/activity/<u></u>activity.py<br>
@@ -962,9 +962,6 @@ class Activity(Window, Gtk.Container):<br>
def get_document_path(self, async_cb, async_err_cb):<br>
async_err_cb(<u></u>NotImplementedError())<br>
<br>
- # DEPRECATED<br>
- _shared_activity = property(lambda self: self.shared_activity, None)<br>
-<br>
<br>
class _ClientHandler(dbus.service.<u></u>Object, DBusProperties):<br>
def __init__(self, bundle_id, got_channel_cb):<br>
</blockquote>
<br>
<br></div>
We need to update the 'get_shared_activity' method as well, tested with Browse HEAD.<br>
<br>
diff --git a/src/sugar3/activity/<u></u>activity.py b/src/sugar3/activity/<u></u>activity.py<br>
index f772679..79c32ea 100644<br>
--- a/src/sugar3/activity/<u></u>activity.py<br>
+++ b/src/sugar3/activity/<u></u>activity.py<br>
@@ -764,7 +764,7 @@ class Activity(Window, Gtk.Container):<br>
<br>
The shared activity is of type sugar3.presence.activity.<u></u>Activity<br>
"""<br>
- return self._shared_activity<br>
+ return self.shared_activity<br>
<br>
def get_shared(self):<br>
"""Returns TRUE if the activity is shared on the mesh."""<br>
<br>
Regards,<br>
Simon<div class="HOEnZb"><div class="h5"><br>
______________________________<u></u>_________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.<u></u>org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/<u></u>listinfo/sugar-devel</a><br>
</div></div></blockquote></div><br>