<br><br><div class="gmail_quote">On Wed, Jan 18, 2012 at 2:07 PM, Gary Martin <span dir="ltr"><<a href="mailto:garycmartin@googlemail.com">garycmartin@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF"><div>Hi Gonzalo,<div class="im"><br></div></div></div></blockquote><div><br>Hey Gary! <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><div><div>It's true. I have added controls to pause/stop in the palette. <br>I have tried with two options (please see <a href="http://wiki.sugarlabs.org/go/Talk:Features/Global_Text_To_Speech" target="_blank">http://wiki.sugarlabs.org/go/Talk:Features/Global_Text_To_Speech</a>)<br>
</div></div><div class="im"><div><br></div></div><div>Thanks for the screenshots, looks like a really useful feature!</div><div><br></div><div>One quick extra comment with my Design hat on. Regarding the Rate and Pitch sliders, they are vertically very close together, and horizontally very short. Keeping in mind our need to support finger sized touch input events, could we separate these two sliders so they take the full width of the palette (see the volume device)? So, we would end up with a full width pitch slider, the word Pitch centred below, a horizontal separator, a full width rate slider, the word Rate centred below.</div>
<div class="im"><br></div></div></blockquote><div><br>Good point. I will try.<br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<div class="im"><blockquote type="cite"><div><div class="gmail_quote"><div>
One option with menu items and the other with buttons. The option with menu items looks better,<br>but when the item is activated, the palette close, then if you want pause/play more than one time <br>is annoying. <br>The option with buttons is better for usability, because the palette is not closed,<br>
but is uglier (the separator does not take all the palette width). Advice is welcomed.<br></div></div></div></blockquote><div><br></div></div><div>I agree with you above ;) the menu item version looks better, more consistent; the buttons version is uglier, looks a little broken. The usability behaviour of keeping the palette open when play/pausing is an important benefit for our target audience (should encourage reading along with the spoken text).</div>
<div><br></div><div>Is it possible to override the menu item so this event doesn't percolate all the way up to triggering the menu to auto close? Sorry my gtk event handeling knowledge is rather slim.</div><div class="im">
<br></div></div></blockquote><div><br>I don't know. Will look.<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<div class="im"><blockquote type="cite"><div><div class="gmail_quote"><div>The code is commented in the patch then is easy test the two options <br>(SpeechPalette __init__ and _set_buttons_state)<br><br>I don't know what to do with the hot key. Pause if the user press when a text is being played?<br>
</div></div></div></blockquote><div><br></div></div><div>A Pause/Play toggle would be good if the system responds fairly quickly (say less than a second). If it's too slow, a user will be tempted to click/touch again and pause before it had a chance to start.</div>
<div><br></div></div></blockquote><div><br>It's reasonable quick. But I need try in a XO-1<br><br>Tanks! Keep your Design hat on :)<br><br>Gonzalo <br><br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><div></div><div>Regards,</div><div>--Gary</div><div class="im"><br><blockquote type="cite"><div><div class="gmail_quote"><div><blockquote type="cite"> <span>- the shortcut is a bit long, maybe 'alt+s' is enough? (see above, maybe there is a shortcut as well for stopping? or hitting it again does stop the current playing one?)</span></blockquote>
</div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br></blockquote><div><br>Ok, changed. To stop we use Ctrl + q<br> <br></div><div> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- it would be great to write in the Feature page a bit more about the what the Feature does and what it does not do, after discussing with you the other day: it is available in the Shell+Activities for any text you select, it does not allow you to do activity specific operations like reading a chapter in Read, or a whole book or a wikipedia activity in Browse nor does it is a primary tool for Accessibility (no criticism intended just to note what it does and what not)<br>
<br>
Formal:<br>
<br>
- there are a few items that do not need to be public e.g. 'self.pipeline' in 'AudioGrabGst'<br>
<br></blockquote><div>I have changed them. Now I have two variables is_playing, is paused visible from outside, then added properties to access them readonly.<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- the copyright in the files is a bit all over the place<br>
<br></blockquote><div>Ok. Changed. <br></div><div> <br>Thanks by the review, the patch is sent to sugar-devel.<br><br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Regards,<br>
Simon<div><div><br>
______________________________<u></u>_________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.<u></u>org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/<u></u>listinfo/sugar-devel</a><br>
</div></div></blockquote></div><br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Sugar-devel mailing list</span><br><span><a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a></span><br>
<span><a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a></span><br></div></blockquote></div></div></blockquote></div><br>