2011/10/6 Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

Thanks Manuel, looks great.<div>A few comments about the patch:</div><div><br></div><div>* There are lines longer than 80 cols.</div><div><br></div><div>* You should not use  _("Export") + ' ' + _("As Pippy Document") but _("Export as Pippy Document")</div>


<div>Nobody can assure in other languages the order will be the same.</div><div><br></div></blockquote><div>+1.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

<div></div><div>* I think we should hide the keepbutton, because is hidden in sugar 0.94 but this activity</div><div>can be used with older Sugar versions, but this should be confirmed with the activity maintainer.</div>

<div><br></div></blockquote><div>+1 indeed.</div><div><br></div><div>Besides from that the patch looks good.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

<div></div><div><font color="#888888">Gonzalo</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">2011/10/6 Manuel Quiñones <span dir="ltr"><<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>></span><br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks!<br>
<br>
Here is a new proposal:<br>
<br>
<a href="http://dev.laptop.org/~manuq/pippy_design/pippy_export-2.png" target="_blank">http://dev.laptop.org/~manuq/pippy_design/pippy_export-2.png</a><br>
<br>
What do you think?  Patch attached.<br>
<br>
2011/10/5 Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>>:<br>
<div><div></div><div>>><br>
>> Why not simply stay with the previous icon for the pippy created bundle<br>
>> (snake over a diamond shape)?<br>
><br>
> +1<br>
> Gonzalo<br>
><br>
</div></div><div><div></div><div>> _______________________________________________<br>
> Sugar-devel mailing list<br>
> <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
><br>
><br>
<br>
<br>
<br>
</div></div><font color="#888888">--<br>
.. manuq ..<br>
</font><br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>