Here is a first patch implementing the proposed changes.<br>This patch, does not include the change to synchronize the model in play and create mode,<br>or the change in the saving procedure, because I think is better do it in a separated patch.<br>
<br>Gonzalo<br><br><div class="gmail_quote">On Mon, Sep 12, 2011 at 9:01 AM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Thanks a lot!<br>I will work on it now.<br><br>Gonzalo<br><br><div class="gmail_quote"><div><div></div><div class="h5">On Sun, Sep 11, 2011 at 9:29 PM, Gary Martin <span dir="ltr"><<a href="mailto:garycmartin@googlemail.com" target="_blank">garycmartin@googlemail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div class="h5"><div style="word-wrap: break-word;"><div>Hi Gonzalo,</div>
<div><div><br></div><div><div>
On 9 Sep 2011, at 18:44, Gonzalo Odiard wrote:<br><br><blockquote type="cite">2011/9/9 manuel quiñones <<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>><br><blockquote type="cite">As Simon said, I think that the cog button should toggle to edit mode<br>
directly, no need for a "click to edit" toggle button in the<br>subtoolbar. As it is a toggle, we should disable activation when<br>hovering on it (I think this has to be done globally for al toggles in<br>a toolbox, maybe a Sugar change?).<br>
<br></blockquote><br>I think this behavior will be inconsistent with all the other activities.<br>We discussed this a lot when implemented Record toolbars.<br></blockquote><div><br></div></div><div>I've been working with Simon on the Memorize toolbar here at Paris Sugar Camp #2, hopefully you'll find this consistent :)</div>
<div><br></div><div>Below are the two mockups, the first shows the Memorize toolbar in Play mode. The activity toolbar is now the only toolbutton with a secondary toolbar. Start new game icon (Memorize icon with the spark badge) is insensitive when the game is in a fresh unused state, and once you start to play and turn over cards Start new becomes sensitive (so the game can be reset – the mockup below shows the initial game state has already been modified). Manual saving and loading of games has been removed:<br>
<br><img src="cid:52B8A820-98A4-4DA1-9A5F-A26A371649BA@home" height="77" width="725"><br><br>The second mockup shows the toolbar in Edit mode. The game playing features are made insensitive, the edit feature made sensitive, and the edit canvas is drawn:<br>
<br><img src="cid:323DA468-1C25-4BFE-952B-2636CF93E4A6@home" height="77" width="725"></div><div><div><br></div><blockquote type="cite"> <br><blockquote type="cite">We should replace the current "click to edit" button with a "New game"<br>
button to start from scratch. The icon can be the one for "click to<br>edit".<br><br> <br>We should change the icon for "restart game", maybe using the sparkle<br>alone? Something in the line of this?<br>
<br><a href="http://dev.laptop.org/%7Emanuq/memorize_design/memorize_restart_button.png" target="_blank">http://dev.laptop.org/~manuq/memorize_design/memorize_restart_button.png</a><br><br></blockquote><br>Hmm, I don't like it. May be we can use a single big sparkle. And change the icon in other similar cases,<br>
like implode.<br></blockquote><div><br></div></div><div>The mockups above show radio switching between the Play mode (using the standard media play icon) and the Edit mode (the cog icon), with the Start new game (reset currently loaded game) functionality using the Memorize icon with the spark badge. It is far away from the Activity icon to avoid confusion, and is made sensitive once a game's state has been modified.</div>
<div><br><blockquote type="cite"> <br><blockquote type="cite">For the clear game button, we may use the icon 'X' inside a square<br>fill, as in Gary's mockup here:<br><br><a href="http://wiki.sugarlabs.org/go/File:Memorize_edit_toolbar_view.png" target="_blank">http://wiki.sugarlabs.org/go/File:Memorize_edit_toolbar_view.png</a><br>
<br></blockquote><br>Yes, this is true. I will replace it<br></blockquote><div><br></div></div><div>Yes, I've used this icon (originally from Paint) in the above mockups, clicking it should clear the current game cards (button is sensitive in edit mode only).</div>
<div><br><blockquote type="cite"> <br><blockquote type="cite">Another thing: I expect that if I edit a game and then come back to<br>play mode, I get the modified game reloaded.<br><br><br></blockquote>Good point. May be, can be updated when we save the game.<br>
If the user restart the game must use the new updated tiles.<br></blockquote><div><br></div></div><div>Editing the cards and then playing should be as seamless as possible. Note that saving and loading have been removed completely from Memorize, the game card set would be kept in its Journal entry. If a user wants to make a new separate set of cards based on an existing set, they would use the new Journal --> Duplicate feature, and then resume that and edit it as needed.</div>
<div><br></div><div>Switching from Edit mode to Play mode would automatically start a new game (with your new card changes), but only if the user has modified the cards (clicking the edit cog icon part way through a game and then clicking play again without card changes should carry on with the existing game).</div>
<div><br><blockquote type="cite"> <br><blockquote type="cite">I would like to discuss this topics in the design meeting next Monday.<br></blockquote></blockquote><div><br></div></div><div>I'll try to stay logged into irc tomorrow as much as possible during the day (before my flight back to the UK), so please do ping so we can talk over any unclear details. The Memorize toolbar rework has been really tricky, it seems to have so many unusual edge cases!</div>
<div><br></div><div>Regards,</div><div>--Gary</div><div><br><blockquote type="cite">Ok, thanks by the review!<br> <br>Regards,<br><br>2011/9/8 Simon Schampijer <<a href="mailto:simon@schampijer.de" target="_blank">simon@schampijer.de</a>>:<br>
> On 09/08/2011 01:33 PM, Gonzalo Odiard wrote:<br>>><br>>> Simon also complained about how is implemented the change of mode to<br>>> create/play.<br>>> Have the Design Team any other idea?<br>
>><br>>> Gonzalo<br>><br>> To phrase out my 'complain':) In the edit sub-toolbar you have to click on<br>> the edit button at the far left to start editing and the edit canvas is<br>> shown. To get out of the edit mode you have to click on that toggle button<br>
> again. It took me a while to figure that out. Maybe the button should<br>> change, based on the mode it is in. Also you can expand/shrink the toolbar<br>> while the full edit view is open which is a bit confusing.<br>
><br>> Another option: I thought to display the full edit view when you click on<br>> the edit button, Gonzalo was worried that this would cause issues when you<br>> hover over the button (maybe we disable hovering in that case?).<br>
><br>> Regards,<br>> Simon<br>><br><br><br><br>--<br>.. manuq ..<br><br></blockquote><br></div></div></div></div><br></div></div>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>
</blockquote></div><br>