Retested!<br>Please push.<br><br>Gonzalo<br><br><div class="gmail_quote">On Wed, Sep 7, 2011 at 3:07 AM, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div class="h5">On 09/06/2011 08:59 PM, Gonzalo Odiard wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Tested and works ok.<br>
IMHO, sending the constants had more sense when we only had two messages,<br>
now should be more clear if we do:<br>
<br>
         if len(tree_model) == 0:<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
             if self._is_query_empty():<br>
-                self._show_message(MESSAGE_<u></u>EMPTY_JOURNAL)<br>
+                if self._query['mountpoints'] == ['/']:<br>
+                    self._show_message(_('Your Journal is empty'))<br>
+                elif self._query['mountpoints'] == \<br>
+                        [model.get_documents_path()]:<br>
+                    self._show_message(_('Your documents folder is<br>
empty'))<br>
+                else:<br>
+                    self._show_message(_('The device is empty'))<br>
             else:<br>
                 self._show_message(_('No matching<br>
entries'),show_clear_query=<u></u>True)<br>
         else:<br>
@@ -385,6 +393,10 @@ class BaseListView(gtk.Bin):<br>
<br>
<br>
</blockquote>
<br>
    def _show_message(self, message, show_clear_query=False):<br>
<br>
   .....<br>
<br>
           if show_clear_query:<br>
             button = gtk.Button(label=_('Clear search'))<br>
             button.connect('clicked', self.__clear_button_clicked_<u></u>cb)<br>
             button.props.image = Icon(icon_name='dialog-cancel'<u></u>,<br>
                                       icon_size=gtk.ICON_SIZE_<u></u>BUTTON)<br>
             canvas_button = hippo.CanvasWidget(widget=<u></u>button,<br>
<br>
xalign=hippo.ALIGNMENT_CENTER)<br>
             box.append(canvas_button)<br>
<br>
<br>
... but is only me.<br>
Regards,<br>
<br>
Gonzalo<br>
</blockquote>
<br></div></div>
Thanks Gonzalo for the feedback. Addressed your suggestion in the follow-up patch. Can you retest before I push?<br>
<br>
Regards,<br><font color="#888888">
   Simon<br>
<br>
<br>
<br>
</font></blockquote></div><br>