Right now, jukebox is not saving anything useful in the journal, then I don't see why we need this toolbar.<br>But this will change soon, because Manuel have a play list patch in the works.<br>Then we can add this toolbar.<br>
<br>Gonzalo <br><br><div class="gmail_quote">2011/9/7 Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Manuel,<br>
<br>
looks good.<br>
<br>
Reviewed-By: Simon Schampijer <<a href="mailto:simon@laptop.org" target="_blank">simon@laptop.org</a>><br>
<br>
Regards,<br><font color="#888888">
Simon<br>
</font><br>
PS: there seem to be an issue with the subtoolbar: when you click on it (lock it in) and click again on it it does not go away anymore. For both the activity and the view toolbar<div><div></div><div class="h5"><br>
<br>
On 09/02/2011 03:02 PM, Manuel Quiñones wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
For new style of toolbars, the activity subtoolbar was missing. It<br>
has the activity title entry and the share button disabled. Set max<br>
participants to one.<br>
<br>
Signed-off-by: Manuel Quiñones<<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>><br>
---<br>
jukeboxactivity.py | 13 +++++++------<br>
1 files changed, 7 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/jukeboxactivity.py b/jukeboxactivity.py<br>
index 0ba3f4c..53539db 100644<br>
--- a/jukeboxactivity.py<br>
+++ b/jukeboxactivity.py<br>
@@ -27,6 +27,7 @@ from gettext import gettext as _<br>
import os<br>
<br>
from sugar.activity import activity<br>
+from sugar.activity.widgets import ActivityToolbarButton<br>
from sugar.graphics.objectchooser import ObjectChooser<br>
from sugar import mime<br>
<br>
@@ -68,6 +69,9 @@ class JukeboxActivity(activity.<u></u>Activity):<br>
<br>
def __init__(self, handle):<br>
activity.Activity.__init__(<u></u>self, handle)<br>
+<br>
+ self.max_participants = 1<br>
+<br>
self._object_id = handle.object_id<br>
self.set_title(_('Jukebox Activity'))<br>
self.player = None<br>
@@ -101,13 +105,10 @@ class JukeboxActivity(activity.<u></u>Activity):<br>
<br>
else:<br>
toolbar_box = ToolbarBox()<br>
- activity_button = ToolButton()<br>
- color = XoColor(profile.get_color())<br>
- bundle = ActivityBundle(activity.get_<u></u>bundle_path())<br>
- icon = Icon(file=bundle.get_icon(), xo_color=color)<br>
- activity_button.set_icon_<u></u>widget(icon)<br>
- activity_button.show()<br>
+<br>
+ activity_button = ActivityToolbarButton(self)<br>
toolbar_box.toolbar.insert(<u></u>activity_button, 0)<br>
+ activity_button.show()<br>
<br>
_view_toolbar = ViewToolbar()<br>
_view_toolbar.connect('go-<u></u>fullscreen',<br>
</blockquote>
<br>
</div></div></blockquote></div><br>