Yes, can be done in either way.<br>is probably a one line patch too, I think you don't need a patch, right ? ;)<br><br>Gonzalo<br><br><div class="gmail_quote">On Mon, Aug 29, 2011 at 11:58 AM, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">On 08/26/2011 11:51 PM, <a href="mailto:godiard@sugarlabs.org" target="_blank">godiard@sugarlabs.org</a> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
From: Gonzalo Odiard<<a href="mailto:godiard@gmail.com" target="_blank">godiard@gmail.com</a>><br>
<br>
After adding the Documents folder in the VolumesToolbar,<br>
if the user unmount a device with the ObjectChooser opened,<br>
the code break and the device button is not removed.<br>
</blockquote>
<br></div>
Thanks Gonzalo for the patch. We could as well store the mountpoint in DocumentsButton, the information is there. That way the '_get_button_for_mount' would return the correct information. What do you think?<br>
<br>
Regards,<br>
Simon<div class="im"><br>
<br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Signed-off-by: Gonzalo Odiard<<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>><br>
---<br>
src/jarabe/journal/<u></u>volumestoolbar.py | 3 ++-<br>
1 files changed, 2 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/src/jarabe/journal/<u></u>volumestoolbar.py b/src/jarabe/journal/<u></u>volumestoolbar.py<br>
index 7a34e18..36f3011 100644<br>
--- a/src/jarabe/journal/<u></u>volumestoolbar.py<br>
+++ b/src/jarabe/journal/<u></u>volumestoolbar.py<br>
@@ -280,7 +280,8 @@ class VolumesToolbar(gtk.Toolbar):<br>
def _get_button_for_mount(self, mount):<br>
mount_point = mount.get_root().get_path()<br>
for button in self.get_children():<br>
- if button.mount_point == mount_point:<br>
+ if hasattr(button, 'mount_point') and \<br>
+ button.mount_point == mount_point:<br>
return button<br>
logging.error('Couldnt find button with mount_point %r', mount_point)<br>
return None<br>
</blockquote>
<br></div>
______________________________<u></u>_________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.<u></u>org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/<u></u>listinfo/sugar-devel</a><br>
</blockquote></div><br>