Thanks for doing all these tests! I really wanted have this feedback, because at times a screenshot is not enough to describe all the different interactions/changes. I will send the new patches. Now! :) Gonzalo PD: I have added a strip() to the queryto avoid filtering with accidentals spaces. <div class="gmail_quote">On Thu, Aug 18, 2011 at 7:04 PM, Gary Martin <<a href="mailto:garycmartin@googlemail.com">garycmartin@googlemail.com</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Hi Gonzalo, <div><div></div><div class="h5"> On 18 Aug 2011, at 17:56, Simon Schampijer wrote: > On 08/18/2011 06:29 PM, Gary Martin wrote: >> Hi Simon, >> >> On 18 Aug 2011, at 16:57, Simon Schampijer<<a href="mailto:simon@schampijer.de">simon@schampijer.de</a>> wrote: >> >>> Hi Gary, >>> >>> On 08/16/2011 07:25 PM, Simon Schampijer wrote: >>>> On 08/16/2011 06:44 PM, Simon Schampijer wrote: >>>>> On 08/16/2011 06:36 PM, Gary Martin wrote: >>>>>> On 16 Aug 2011, at 17:30, Simon Schampijer wrote: >>>>>> >>>>>>> On 08/16/2011 06:10 PM, Gonzalo Odiard wrote: >>>>>>>>> >>>>>>>>> Thanks for the screen shots. For the grey version the stroke should >>>>>>>>> be grey >>>>>>>>> and the fill white (to match the background) so that the icon >>>>>>>>> detail is >>>>>>>>> still visible. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> --Gary >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> Ok. I have applying the same colors than in the neighborhood view for >>>>>>>> consistency, >>>>>>>> but is a easy change if we define it. >>>>>>>> >>>>>>>> Do you need a screenshot with this colors? >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> Gonzalo >>>>>>> >>>>>>> I think Gary means this: >>>>>>> <a href="http://dev.laptop.org/%7Eerikos/filter_search/neighborhood_view.png" target="_blank">http://dev.laptop.org/~erikos/filter_search/neighborhood_view.png</a> >>>>>>> >>>>>>> Without your patches applied I am getting these results in the >>>>>>> neighborhood view. >>>>>> >>>>>> Well spotted, yes. I was just checking the access-point and mesh icons >>>>>> here – didn't have any shared activity icons to see. >>>>>> >>>>>> Regards, >>>>>> --Gary >>>>> >>>>> And this is how it looks like then in the home view: >>>>> <a href="http://dev.laptop.org/%7Eerikos/filter_search/home-view.png" target="_blank">http://dev.laptop.org/~erikos/filter_search/home-view.png</a> >>>> >>>> Gary, with that change I think the greying out does work nicely. What is >>>> about the 'unfocusing' of the entry you mentioned yesterday? When would >>>> this be needed, only after start, but then it grabs focus when for >>>> example switching the views? Can you flash that out a bit more, I am >>>> myself a bit unclear on that. >>>> >>>> Regards, >>>> Simon >>> >>> I want to do tarballs today and patch wise Gonzalo's Feature looks good. I was a bit worried about the possible issue described above. How shall we proceed? Do you think it is that much of an issue? As I said, I am a bit unsure myself. >> >> OK I had a bit of a review yesterday and experimented with the old favorites filter implementation (before it was disabled just prior to an old release). The previous filter's negative sides were that: 1) it switched the user from the favourites view to the list view for presenting the results (not obvious for a novice user how to escape that view); 2) that the list view hides all non-matching activities completely from the view (easy to end up with a blank set of filter results if you accidently press a couple of random keys). Gonzalo's feature implementation avoids both those issues, and even allows the ghosted items still to be interacted with, so I'm happy so see it land. >> >> Just to confirm, the new filter visual effect is also used in the neighbourhood and group views for consistancy? >> >> Regards, >> --Gary > > Thanks a lot Gary for your quick reply! Great that you did the research - and even with a positive result. Sounds good to me then. Will get it into the build and we have until next Monday to adjust visually. > > Yes the new filter effect [1] will be the same as in the neighborhood view. </div></div>As per our IRC chat tonight, many thanks for sending me the files to test on a Sugar 0.92.2 build, I've had a good experiment with the different filters (grey, and alpha at .2 and .33) on an XO-1 running in both backlight colour and reflective monochrome mode. I tested with 40 icons in the favourite spiral with some non-sugar compliant activity icons installed. I think an alpha fade version at 0.33 works best: 1) it avoids the problem with non-sugar compliant icons not filter fading (the grey fade effect only works on icons correctly using fill and stroke entities) 2) it still gives some detail in reflective monochrome mode (though not quite as clear as the grey/clear only effect) 3) pressing the alt key (so icon clicks become 'Start new' rather than 'Resume') with a filter string keeps displaying the filter correctly (with the grey effect while you press alt, the light grey filter effect vanishes as it's replaced by the darker grey effect used for Start new). 4) it avoids the possible confusion between the filter grey effect vs. activity icons in the favourite view not yet started (that use a slightly darker grey outline colour). An accidental filter search could make icons look like they had no resume state (e.g. an accidental press of the space bar). When testing the 0.33 alpha filtering patch on an XO-1 with 40 icons in a spiral, it's dimming the icons in a respectable ~1sec after the last filter input key press. So performance on an XO-1 seems good as well. Would be great if the Neighbourhood filter effect could match the filter effect landed for home favourites view to keep consistency between views. Regards, --Gary P.S. Apologies to all for such late additional feedback. Lovely to see this long lost feature back, especially now that we have the spiral home layout that works well with many more icons on screen. <div><div></div><div class="h5"> > Regards, > Simon > > PS: there is no filter in the groups view, yet...psst Gonzalo psst :) > > [1] <a href="http://dev.laptop.org/%7Eerikos/filter_search/home-view.png" target="_blank">http://dev.laptop.org/~erikos/filter_search/home-view.png</a> > _______________________________________________ > Sugar-devel mailing list > <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a> > <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a> </div></div></blockquote></div>