<br><br><div class="gmail_quote">On Sat, Jul 30, 2011 at 7:30 PM, Rafael Ortiz <span dir="ltr"><<a href="mailto:rafael@activitycentral.com">rafael@activitycentral.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On Fri, Jul 29, 2011 at 6:34 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br></div><div class="gmail_quote"><div class="im"> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Hi James,<br>There are no problem, the KeepButton class is not removed, but is not added by default in the toolbar.<br>The activities will work ok.<br><font color="#888888"><br></font></blockquote><div><br></div></div><div> James, +1. </div> <div><br></div><div>You can remove the code w/o problem, if you don't remove it, the activity won't work but only for sugar >=0.94 (as I understand it from Simon) , this is only for activities that have the keepbutton ''hardcoded'' in the activity toolbar code. </div> </div></blockquote><div><br><br>Rafael:<br>This is not correct.<br>The activity will continue working, because the class KeepButton was not removed (there are two proposed patches, look at the second)<br>In most of the activities, the default Activity Tolbar is used, and in sugar 0.94, the KeepButton will not be displayed.<br> In a few activities, the developer hidden the button, or used a custom toolbar, and we provided patches to resolve them.<br>Of course, we did not checked the hundred of activities in ASLO, but only the activities included by default in OLPC image,<br> then if another activity use the button (or the user is using a old version of the activity) the only difference will be<br>the KeepButton will be present, but the activity will works ok.<br><br>Gonzalo<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="gmail_quote"><div><div></div><div class="h5"> <div> </div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><font color="#888888">Gonzalo<br><br></font><div class="gmail_quote"> <div><div></div><div> On Fri, Jul 29, 2011 at 12:39 PM, James Simmons <span dir="ltr"><<a href="mailto:nicestep@gmail.com" target="_blank">nicestep@gmail.com</a>></span> wrote:<br> </div></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div>Rafael,<div><br></div><div>One of my concerns is that the Keep button is useless or misleading for all of my Activities. That's why I hide it. I also show how to hide it in my book "Make Your Own Sugar Activities!" That is why I'd prefer that the Keep button be hidden by default. Hiding it a second time won't hurt anything, and if someone actually has a use for it they can show it. Just removing it breaks backward compatibility. I go to a fair amount of effort to make Activities that support any version of Sugar, including using the new toolbars when they are available. I don't want students to have to wonder if one of my Activities will work for them. I know that full backwards compatibility is not possible for every Activity, but if you do Python without components other than GTK it should still be possible.</div> <div><br></div><div><font color="#888888">James Simmons</font><div><div></div><div><br><br><div class="gmail_quote">On Fri, Jul 29, 2011 at 9:57 AM, Rafael Ortiz <span dir="ltr"><<a href="mailto:rafael@activitycentral.com" target="_blank">rafael@activitycentral.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Simon, James<div><br></div><div>Thanks for pointing out the cases where the activities can fail.</div> <div><br></div><div> I think it's all clear for activity devs to follow. </div><div><br></div><div>Recommendation: Remove keep button of all your activities if you have it on the toolbars code. In order to have compatibility for sugar >=0.94.</div> <div><br></div><div>Thanks and cheers.</div><div><div></div><div><div><br></div><div> <br><br><div class="gmail_quote">On Fri, Jul 29, 2011 at 8:15 AM, Simon Schampijer <span dir="ltr"><<a href="mailto:simon@schampijer.de" target="_blank">simon@schampijer.de</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div><div></div><div>On 07/29/2011 02:54 PM, James Simmons wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Simon and Rafael,<br> <br> My Activities don't have any use for the Keep button, so they hide it. As a<br> result, if you just remove the Keep button they'll stop working. Maybe for<br> backward compatibility keep the button but hide it by default?<br> <br> James Simmons<br> <br> Just to be clear if we remove the keep button from an activity it wont open<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> in previous sugar versions than 0.94<br> </blockquote></blockquote> <br></div></div> The use of the Keep button will be deprecated for a development cycle, only, see [1]. But I would still recommend you to remove the hide the keep button from your activity.<br> <br> Regards,<br> Simon<br> <br> [1] <a href="http://lists.sugarlabs.org/archive/sugar-devel/2011-July/032438.html" target="_blank">http://lists.sugarlabs.org/<u></u>archive/sugar-devel/2011-July/<u></u>032438.html</a><br> </blockquote></div><br></div> </div></div></blockquote></div><br></div></div></div> <br></div></div><div>_______________________________________________<br> Sugar-devel mailing list<br> <a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> <br></div></blockquote></div><br> </blockquote></div></div></div><br> <br>_______________________________________________<br> Sugar-devel mailing list<br> <a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br> <a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br> <br></blockquote></div><br>