Any Sugar hacker can do a review of this patches? The ticket is <a href="http://dev.laptop.org/ticket/10930">http://dev.laptop.org/ticket/10930</a> Thanks Gonzalo <div class="gmail_quote">On Thu, Jun 23, 2011 at 10:53 AM, Gonzalo Odiard <<a href="mailto:gonzalo@laptop.org">gonzalo@laptop.org</a>> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">I was working in the solution of OLPC #10930 "copy/paste does not work in if one has not revealed the edit toolbar once" The problem can be reproduced in activities with the new toolbars, like Terminal or Browse. For example, in Terminal, if you open the activity, select a text and press "Shift-Ctrl-C", nothing is copied, if you show the Edit toolbar and try pressing "Sift-Ctrl-C" again, the text is copied. The same happen in Browse with "Ctrl-C" I have worked in two different solutions: 1) <a href="http://dev.laptop.org/attachment/ticket/10930/0001-Update-accelerators-when-the-toolbar-is-set-in-the-a.patch" title="View attachment" target="_blank">0001-Update-accelerators-when-the-toolbar-is-set-in-the-a.patch</a> The patch walk the objects in the toolbar_box when is set in the activity and update the accelerators. This patch resolve the problem in activities Terminal and Browse without changing the activities. If in one activity the programmer set the toolbar_box in the activity before adding all the buttons, must call the update_accelerators methods after add the controls. Additionally, we can remove the 'hierarchy-changed' signal handlers in toolbutton.py <a href="http://dev.laptop.org/attachment/ticket/10930/0001-Remove-hierachy-changed-signal-handlers-in-toolbutto.patch" title="View attachment" target="_blank">0001-Remove-hierachy-changed-signal-handlers-in-toolbutto.patch</a> This code is called many times at the start of the activity, and later every time we show or hide a toolbar. 2) Another solution is <a href="http://dev.laptop.org/attachment/ticket/10930/0001-Pack-page-in-ToolbarButton-when-is-conected-to-the-w.patch" title="View attachment" target="_blank">0001-Pack-page-in-ToolbarButton-when-is-conected-to-the-w.patch</a> I don't like it, but is a fix using the same technique used in toolbutton.py, Uses the 'hierarchy-changed' signal to pack the toolbar to the toolbarbutton, udating the hierachy of the children and enabling them to setup the accelerators. The problem with this approach is the code is executed many times, because the toolbars change the parents every time are visible/invisible. Comments? Gonzalo </blockquote></div>