<br><div class="gmail_quote">On Sat, Jun 18, 2011 at 11:23 AM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><br><div class="gmail_quote"><div>On Sat, Jun 18, 2011 at 8:44 AM, Sascha Silbe <span dir="ltr"><<a href="mailto:sascha-ml-reply-to-2011-3@silbe.org" target="_blank">sascha-ml-reply-to-2011-3@silbe.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
Excerpts from Gonzalo Odiard's message of Wed Jun 08 17:04:41 +0200 2011:<br>
<div><br>
> To test with multiple tabs, in F14 I needed to replace:<br>
><br>
> - self._disable_multiple_tabs = cairo.cairo_version() >= 10810<br>
> + self._disable_multiple_tabs = cairo.cairo_version() >= 10810 \<br>
> + and cairo.cairo_version() < 11002<br>
><br>
> I don't know if is in your plans restore multiple tabs, functionality in<br>
> F14,<br>
> but the cairo bug is gone.<br>
<br>
</div>That's great news! I'd appreciate if someone could check which cairo<br>
version (at least of those that are shipped by distributions) was the<br>
first to fix all the tabbing related bugs (IIRC there were several<br>
different bugs) so we can adjust the check accordingly.<br></blockquote></div><div><br>Anybody with a F13 or F12 environment?<br>I can only confirm the F14 case, and I think the next images from OLPC and AC <br>will be based in it.</div>
</div></blockquote><div><br></div><div>Just tested this with a little change under F11 (cairo.cairo_version()=11000), it works, so we can change the patch to </div><div><br></div><div> + self._disable_multiple_tabs = cairo.cairo_version() >= 10810 \</div>
<div>> + and cairo.cairo_version() < 11000</div><div><br></div><div>Should work for all the posterior F versions. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div>
<font color="#888888">
<br>Gonzalo<br><br></font></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><div>
<br>
We only deactivate the UI for creating new tabs, BTW - they can still be<br>
created using JavaScript, which is how I tested your patch.<br>
<font color="#888888"><br>
Sascha<br>
</font><div><div></div><div><br></div></div></div></blockquote></div></blockquote><div><br></div><div>The code comment </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex"><div><div><div>
--<br>
<a href="http://sascha.silbe.org/" target="_blank">http://sascha.silbe.org/</a><br>
<a href="http://www.infra-silbe.de/" target="_blank">http://www.infra-silbe.de/</a><br>
</div></div><br></div><div>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></div></blockquote></div><br>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>