Yes, Manu is working with me.<br>About the patchs from Sebastian, in what other activities have you worked?<br>Can you send the patches to sugar-devel? <br>The merge request does not work, because nobody receive a mail and there are not review.<br>
<br>Gonzalo<br><br><div class="gmail_quote">2011/5/19 Rafael Ortiz <span dir="ltr"><<a href="mailto:rafael@activitycentral.com">rafael@activitycentral.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hi Manu.<br><br><div class="gmail_quote"><div><div></div><div class="h5">2011/5/18 manuel quiñones <span dir="ltr"><<a href="mailto:manuel.por.aca@gmail.com" target="_blank">manuel.por.aca@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Hello,<br>
<br>
Here is a patch to use the new toolbar for the Jukebox activity. A<br>
few notes about the changes below:<br>
<br>
You will notice that I renamed the ControlToolbar class to just<br>
Control, that's because it doesn't inherit anymore from gtk.Toolbar,<br>
now the toolbar is a property of that class, that can be the old one<br>
or the new one.<br>
<br>
I moved the fullscreen button to a View subtoolbar for consistency<br>
with other activities.<br>
<br>
Regards,<br>
<font color="#888888"><br></font></blockquote><div><br></div></div></div><div>I think that Sebastian Silva (on cc) has a merge request to fix this issue also. </div><div><br></div><div><a href="http://git.sugarlabs.org/jukebox/mainline/merge_requests/2" target="_blank">http://git.sugarlabs.org/jukebox/mainline/merge_requests/2</a></div>
<div> </div><div> Would be nice if you two work with kushal to have this merged into mainline and packaged into a new release.</div><div><br></div><div>Thanks for your patch, gonzalo has a list of activities that </div><div>
need a new toolbar if you want to work on those :).</div><div><br></div><div><a href="http://dev.laptop.org/query?status=assigned&status=new&status=reopened&summary=%7Ehas+old+toolbar&col=id&col=summary&col=status&col=type&col=priority&col=milestone&col=component&order=priority" target="_blank">http://dev.laptop.org/query?status=assigned&status=new&status=reopened&summary=~has+old+toolbar&col=id&col=summary&col=status&col=type&col=priority&col=milestone&col=component&order=priority</a></div>
<div> </div><div><br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><font color="#888888">
--<br>
.. manuq ..<br>
</font><br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org" target="_blank">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>